Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for image params for disconnected #375

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Add support for image params for disconnected #375

merged 1 commit into from
Jul 26, 2023

Conversation

VaishnaviHire
Copy link
Member

Fixes #293

Description

How Has This Been Tested?

  1. Deploy test catalogsource
quay.io/vhire/opendatahub-operator-catalog:v2.0.1
  1. Enable datascience pipelines component
  2. Verify Datascience pipelines operator pod defines env variables added in the CSV file.

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@VaishnaviHire VaishnaviHire requested review from etirelli and zdtsw July 26, 2023 13:23
@openshift-ci openshift-ci bot requested a review from LaVLaS July 26, 2023 13:23
zdtsw
zdtsw approved these changes Jul 26, 2023
View reviewed changes
Copy link
Member

@zdtsw zdtsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jul 26, 2023
@VaishnaviHire
Copy link
Member Author

/retest

etirelli
etirelli approved these changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@etirelli etirelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link

openshift-ci bot commented Jul 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: etirelli, zdtsw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 385f72a into opendatahub-io:feature-rearchitecture Jul 26, 2023
@VaishnaviHire VaishnaviHire mentioned this pull request Aug 4, 2023
Closed
9 tasks
grdryn pushed a commit to grdryn/opendatahub-operator that referenced this pull request Nov 28, 2024
@zdtsw
update: CSV parts missing in downstream (opendatahub-io#375)
ab08cac 
- change CPU back to old value which is being used for production
- we will need to revisit values set there but not done any perf test
- did not add "subs" here

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zdtsw zdtsw zdtsw approved these changes

@etirelli etirelli etirelli approved these changes

@LaVLaS LaVLaS Awaiting requested review from LaVLaS

Assignees

@etirelli etirelli

@zdtsw zdtsw

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@VaishnaviHire @etirelli @zdtsw @openshift-merge-robot