Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add apply manifests for dashboard ISV #346

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Add apply manifests for dashboard ISV #346

merged 1 commit into from
Jul 26, 2023

Conversation

zdtsw
Copy link
Member

@zdtsw zdtsw commented Jul 19, 2023

Description

need go with red-hat-data-services/odh-manifests#414

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci openshift-ci bot requested review from etirelli and LaVLaS July 19, 2023 15:55
@zdtsw zdtsw requested review from VaishnaviHire and removed request for LaVLaS July 19, 2023 15:55
@zdtsw zdtsw marked this pull request as draft July 20, 2023 13:20
@zdtsw
Add apply manifests for dashboard ISV
0d4c176 
Signed-off-by: Wen Zhou <wenzhou@redhat.com>
@zdtsw zdtsw force-pushed the feature/rrearchitecture_dashboard_isv branch from f091e41 to 0d4c176 Compare July 21, 2023 15:58
@zdtsw zdtsw marked this pull request as ready for review July 25, 2023 13:50
VaishnaviHire
VaishnaviHire approved these changes Jul 25, 2023
View reviewed changes
Copy link
Member

@VaishnaviHire VaishnaviHire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jul 25, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jul 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: VaishnaviHire

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zdtsw
Copy link
Member Author

zdtsw commented Jul 26, 2023

/retest

@openshift-merge-robot openshift-merge-robot merged commit 4ee039e into opendatahub-io:feature-rearchitecture Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VaishnaviHire VaishnaviHire VaishnaviHire approved these changes

@etirelli etirelli Awaiting requested review from etirelli

Assignees

@VaishnaviHire VaishnaviHire

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zdtsw @VaishnaviHire @openshift-merge-robot