Implement DSCInitialization Controller #249
Conversation
0e8606d to
1553ed3
Compare
8154032 to
6e39df1
Compare
fd8346a to
9be4aef
Compare
9be4aef to
46d5f6e
Compare
| - bases/odhapplications.dashboard.opendatahub.io_odhapplications.yaml | ||
| - bases/odhdashboardconfigs.opendatahub.io_odhdashboardconfigs.yaml | ||
| - bases/odhdocuments.dashboard.opendatahub.io_odhdocuments.yaml | ||
| - bases/odhquickstarts.console.openshift.io_odhquickstarts.yaml |
There was a problem hiding this comment.
Folder should be base not bases if you are attempting to follow the base/overlay kustomize convention.
The kustomization.yaml file should also be in the base folder by convention.
This is more personal preference, but I usually have a strong aversion from deploying anything from a base folder. At a minimum I almost always create an overlays/default folder that simply references the base. This gives you more flexibility if you later need to introduce an alternative overlay and you may need to move something from the base to the default overlay without impacting anything that is currently deploying from the default overlay.
With that being said, I'm unsure what the use case for overlays in the operator might be or when you might want to leverage an overlay strategy here so it may just make more sense to drop the bases folder entirely and put everything directly in the crd folder.
There was a problem hiding this comment.
This kustomize format is generated by the operator-sdk/kubebuilder when we run operator-sdk generate manifests.
You are correct, with respect to having default folder. For application manifests, we do check for kustomization.yaml file or default. So components are expected to have a default manifest path.
|
From today's sync up -
Moving to wip to address above comments |
46d5f6e to
8e4580d
Compare
This commit adds logic to create common resources like network policies, namespaces etc using dscinitialization_controller
CRDs taken from https://github.com/red-hat-data-services/odh-deployer/tree/main/odh-dashboard/crds and integrated into bundle, enabling discoverability at the OpenShift dashboard for the installed operator
8e4580d to
78c1d61
Compare
|
|
||
| instance := &dsci.DSCInitialization{} | ||
| err := r.Client.Get(ctx, req.NamespacedName, instance) | ||
| // Only apply reconcile logic to 'default' instance of DataScienceInitialization | ||
| err := r.Client.Get(ctx, types.NamespacedName{Name: "default"}, instance) |
There was a problem hiding this comment.
very minor nitpick, maybe set a constant for "default" as it is also used in the predicate below?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: etirelli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Update pkg/upgrade/upgrade.go fix linter Signed-off-by: Wen Zhou <wenzhou@redhat.com> Co-authored-by: Vaishnavi Hire <vhire@redhat.com>
Introduces changes defined in #245
Description
How Has This Been Tested?
Test already built image
defaultDSCInitialization instance is createdopendatahubnamespace is created with networkpolicies and odh specific labelsTest custom image build
Issues
Fix Path for local manifest bundle
Merge criteria: