Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use {IMAGE_BUILDER} in Makefile for opm index cmd #222

Merged
merged 1 commit into from
Apr 6, 2023
Merged

Use {IMAGE_BUILDER} in Makefile for opm index cmd #222

merged 1 commit into from
Apr 6, 2023

Conversation

LaVLaS
Copy link
Contributor

@LaVLaS LaVLaS commented Apr 6, 2023

Description

Add the ${IMAGE_BUILDER} variable to the make catalog-build target to resolve errors when docker is not installed on the system

How Has This Been Tested?

run make catalog-build to generate a catalog image successfully

Merge criteria:

You can successfully run make catalog-build when only podman is installed

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@LaVLaS
Use {IMAGE_BUILDER} in Makefile for opm index cmd
475a65f 
Signed-off-by: Landon LaSmith <LLaSmith@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Apr 6, 2023 •
edited
Loading

@LaVLaS: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/opendatahub-manifests-e2e 475a65f link false /test opendatahub-manifests-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

VaishnaviHire
VaishnaviHire approved these changes Apr 6, 2023
View reviewed changes
Copy link
Member

@VaishnaviHire VaishnaviHire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Apr 6, 2023
@openshift-ci
Copy link

openshift-ci bot commented Apr 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: VaishnaviHire

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Apr 6, 2023
@VaishnaviHire
Copy link
Member

/retest

@openshift-merge-robot openshift-merge-robot merged commit 30f5914 into opendatahub-io:master Apr 6, 2023
VaishnaviHire pushed a commit to VaishnaviHire/opendatahub-operator that referenced this pull request Mar 19, 2024
@zdtsw
feat(dspv2): update manifests path for new overlay struct (opendatahu…
822ad1f 
…b-io#891) (opendatahub-io#222)

* feat(dspv2): update manifests path
* update: remove apply on "base" since overlays/odh does include "base"
---------

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VaishnaviHire VaishnaviHire VaishnaviHire approved these changes

@anishasthana anishasthana Awaiting requested review from anishasthana

Assignees

@VaishnaviHire VaishnaviHire

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LaVLaS @VaishnaviHire @openshift-merge-robot