Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up base for operator rework #162

Conversation

anishasthana
Copy link
Member

Close #157

Signed-off-by: Anish Asthana <anishasthana1@gmail.com>
…elines

Signed-off-by: Anish Asthana <anishasthana1@gmail.com>
@anishasthana
Copy link
Member Author

I'd look at this PR commit by commit

LICENSE Show resolved Hide resolved
PROJECT Show resolved Hide resolved
Makefile Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
config/default/kustomization.yaml Outdated Show resolved Hide resolved
config/default/kustomization.yaml Outdated Show resolved Hide resolved
config/manager/manager.yaml Outdated Show resolved Hide resolved
@VaishnaviHire
Copy link
Member

/lgtm

Copy link

@crobby crobby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a fine skeletal prototype to me

Copy link
Contributor

@LaVLaS LaVLaS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
config/default/kustomization.yaml Outdated Show resolved Hide resolved
Signed-off-by: Anish Asthana <anishasthana1@gmail.com>
@samuelvl
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label May 27, 2022
@openshift-ci
Copy link

openshift-ci bot commented May 27, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anishasthana, LaVLaS, samuelvl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [LaVLaS,anishasthana]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@crobby crobby merged commit 06189f7 into opendatahub-io:operator_rework_prototype May 27, 2022
@anishasthana anishasthana deleted the remove_old_operator_code branch May 31, 2022 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants