Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: add cleanup logic to kserve tests to ensure no KnativeServing instances are present in the cluster #1523

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

lburgazzoli
Copy link
Contributor

Description

How Has This Been Tested?

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link

openshift-ci bot commented Jan 20, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@lburgazzoli lburgazzoli requested a review from ykaliuta January 20, 2025 09:20
@lburgazzoli
Copy link
Contributor Author

Follow up for #1522

Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 19.69%. Comparing base (72443c5) to head (0e2d9e8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1523   +/-   ##
=======================================
  Coverage   19.69%   19.69%           
=======================================
  Files         161      161           
  Lines       11102    11102           
=======================================
  Hits         2187     2187           
  Misses       8683     8683           
  Partials      232      232           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lburgazzoli lburgazzoli marked this pull request as ready for review January 20, 2025 10:00
@openshift-ci openshift-ci bot requested review from lphiri and robotmaxtron January 20, 2025 10:00
Copy link

openshift-ci bot commented Jan 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ykaliuta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ykaliuta
Copy link
Contributor

I do not know if you want add #1524

@lburgazzoli
Copy link
Contributor Author

I do not know if you want add #1524

you mean, removing the log ?

@ykaliuta
Copy link
Contributor

I do not know if you want add #1524

you mean, removing the log ?

yes, but it's @zdtsw proposal.

@lburgazzoli
Copy link
Contributor Author

lburgazzoli commented Jan 20, 2025

I'd keep it around for a while, just to help troubleshooting things, but ideally I'd like to remove it once we found/fix the root cause

@openshift-merge-bot openshift-merge-bot bot merged commit 3e897ce into opendatahub-io:main Jan 20, 2025
10 checks passed
@lburgazzoli lburgazzoli deleted the kserve-e2e branch January 20, 2025 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants