-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2e: add cleanup logic to kserve tests to ensure no KnativeServing instances are present in the cluster #1523
e2e: add cleanup logic to kserve tests to ensure no KnativeServing instances are present in the cluster #1523
Conversation
…stances are present in the cluster
Skipping CI for Draft Pull Request. |
Follow up for #1522 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1523 +/- ##
=======================================
Coverage 19.69% 19.69%
=======================================
Files 161 161
Lines 11102 11102
=======================================
Hits 2187 2187
Misses 8683 8683
Partials 232 232 ☔ View full report in Codecov by Sentry. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ykaliuta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I do not know if you want add #1524 |
you mean, removing the log ? |
I'd keep it around for a while, just to help troubleshooting things, but ideally I'd like to remove it once we found/fix the root cause |
3e897ce
into
opendatahub-io:main
Description
How Has This Been Tested?
Screenshot or short clip
Merge criteria