Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: address comments for monitoring component #1520

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zdtsw
Copy link
Member

@zdtsw zdtsw commented Jan 19, 2025

Description

How Has This Been Tested?

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link

openshift-ci bot commented Jan 19, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from zdtsw. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zdtsw zdtsw requested review from lburgazzoli and VaishnaviHire and removed request for jackdelahunt and biswassri January 19, 2025 16:47
@zdtsw zdtsw changed the title chore: address comments from pervious review chore: address comments for monitoring component Jan 19, 2025
- more if to switch...case
- add .status.condition.MonitoringReady type

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
@zdtsw
Copy link
Member Author

zdtsw commented Jan 19, 2025

/test opendatahub-operator-e2e

Copy link

codecov bot commented Jan 19, 2025

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.

Project coverage is 19.67%. Comparing base (72443c5) to head (0122376).

Files with missing lines Patch % Lines
...rvices/monitoring/monitoring_controller_actions.go 0.00% 20 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1520      +/-   ##
==========================================
- Coverage   19.69%   19.67%   -0.03%     
==========================================
  Files         161      161              
  Lines       11102    11116      +14     
==========================================
  Hits         2187     2187              
- Misses       8683     8697      +14     
  Partials      232      232              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@biswassri
Copy link
Contributor

@zdtsw Can you help also link the PR comment here? So that anyone trying to understand the changes can go back and read the context?

@zdtsw
Copy link
Member Author

zdtsw commented Jan 20, 2025

@zdtsw Can you help also link the PR comment here? So that anyone trying to understand the changes can go back and read the context?

updated in description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

2 participants