-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add install for Authroino operator #1519
base: main
Are you sure you want to change the base?
Conversation
/test opendatahub-operator-e2e |
@@ -436,6 +437,7 @@ func ensureServicemeshOperators(t *testing.T, tc *testContext) error { //nolint: | |||
ops := []string{ | |||
serverlessOpName, | |||
servicemeshOpName, | |||
authorinoOpName, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created that time bomb, but probably makes sense to rename ensureServicemeshOperators to ensureDependencyOperators or something (did @VaishnaviHire already do it somewhere?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated the fuction name to ensureDependencyOperators
/test opendatahub-operator-e2e |
Look good to me. Not adding lgtm since it's do-not-merge |
- rename function to reflect it is not only for servicemesh operator - without authorino installed, we have functions for dependency are not tested Signed-off-by: Wen Zhou <wenzhou@redhat.com>
Signed-off-by: Wen Zhou <wenzhou@redhat.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ykaliuta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@zdtsw: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
i probably need to get openshift/release#60470 out first, |
Description
How Has This Been Tested?
Screenshot or short clip
Merge criteria