Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport] fix: networkpolicy #1518

Merged
merged 3 commits into from
Jan 20, 2025

Conversation

zdtsw
Copy link
Member

@zdtsw zdtsw commented Jan 18, 2025

  • rhoai both self and managed need networkpolicy on redhat-ods-operator namespace

(cherry picked from commit c2c38e2)
Signed-off-by: Wen Zhou wenzhou@redhat.com

Description

this commit is done during testing rhoai build and found networkpolicy for monitoring is missing in the cache for operator namespace. on the same side to add it for all case even ODH

How Has This Been Tested?

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci openshift-ci bot requested review from AjayJagan and grdryn January 18, 2025 15:21
Copy link

codecov bot commented Jan 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 19.69%. Comparing base (8fcf629) to head (3149a91).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1518   +/-   ##
=======================================
  Coverage   19.69%   19.69%           
=======================================
  Files         161      161           
  Lines       11102    11102           
=======================================
  Hits         2187     2187           
  Misses       8683     8683           
  Partials      232      232           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zdtsw zdtsw requested review from lburgazzoli and removed request for grdryn and AjayJagan January 18, 2025 16:43
@zdtsw zdtsw force-pushed the fix_17688_1 branch 2 times, most recently from 9983a9c to 151f974 Compare January 20, 2025 09:57
- rhoai both self and managed need networkpolicy on redhat-ods-operator namespace

(cherry picked from commit c2c38e2)
Signed-off-by: Wen Zhou <wenzhou@redhat.com>
main.go Outdated
@@ -268,6 +269,9 @@ func main() { //nolint:funlen,maintidx,gocyclo
&rbacv1.RoleBinding{}: {
Namespaces: oDHCache,
},
&ofapiv1alpha1.Subscription{}: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is likely unrelated

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forgot to push the new change which reverted this part.....

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm label Jan 20, 2025
@openshift-ci openshift-ci bot added the lgtm label Jan 20, 2025
Copy link

openshift-ci bot commented Jan 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lburgazzoli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit ec01ee8 into opendatahub-io:main Jan 20, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants