-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[backport] fix: networkpolicy #1518
[backport] fix: networkpolicy #1518
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1518 +/- ##
=======================================
Coverage 19.69% 19.69%
=======================================
Files 161 161
Lines 11102 11102
=======================================
Hits 2187 2187
Misses 8683 8683
Partials 232 232 ☔ View full report in Codecov by Sentry. |
9983a9c
to
151f974
Compare
- rhoai both self and managed need networkpolicy on redhat-ods-operator namespace (cherry picked from commit c2c38e2) Signed-off-by: Wen Zhou <wenzhou@redhat.com>
main.go
Outdated
@@ -268,6 +269,9 @@ func main() { //nolint:funlen,maintidx,gocyclo | |||
&rbacv1.RoleBinding{}: { | |||
Namespaces: oDHCache, | |||
}, | |||
&ofapiv1alpha1.Subscription{}: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is likely unrelated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
forgot to push the new change which reverted this part.....
Signed-off-by: Wen Zhou <wenzhou@redhat.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lburgazzoli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ec01ee8
into
opendatahub-io:main
(cherry picked from commit c2c38e2)
Signed-off-by: Wen Zhou wenzhou@redhat.com
Description
this commit is done during testing rhoai build and found networkpolicy for monitoring is missing in the cache for operator namespace. on the same side to add it for all case even ODH
How Has This Been Tested?
Screenshot or short clip
Merge criteria