chore: remove generics from Reconcier and use PlatformObject as base object type

[lburgazzoli]

Description

• remove generics from Reconciler struct as it is not needed
• set PlatformObject as the base obnject that the Reconciler handles to
  ensure the reconciler can access to common objects fields

How Has This Been Tested?

Screenshot or short clip

Merge criteria

• You have read the contributors guide.
• Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
• Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has manually tested the changes and verified that the changes work

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ykaliuta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ykaliuta]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[lburgazzoli]

/retest

[lburgazzoli]

/retest

[lburgazzoli]

/retest

[codecov]

Codecov Report

Attention: Patch coverage is 23.52941% with 13 lines in your changes missing coverage. Please review.

Project coverage is 19.72%. Comparing base (72443c5) to head (59227d1).

Files with missing lines	Patch %	Lines
pkg/controller/reconciler/reconciler.go	0.00%	12 Missing ⚠️
pkg/controller/reconciler/reconciler_support.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1514      +/-   ##
==========================================
+ Coverage   19.69%   19.72%   +0.02%     
==========================================
  Files         161      161              
  Lines       11102    11105       +3     
==========================================
+ Hits         2187     2190       +3     
  Misses       8683     8683              
  Partials      232      232              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[lburgazzoli]

Keeps failing because existing KNativeServing resource was found; integrating to an existing installation is not supported

[lburgazzoli]

/test all

[openshift-ci]

New changes are detected. LGTM label has been removed.

[lburgazzoli]

keep failing because of existing KNativeServing resource was found:

{"level":"info","ts":"2025-01-18T20:51:37Z","logger":"DataScienceCluster","msg":"DataScienceCluster Deployment Completed.","controller":"datasciencecluster","controllerGroup":"datasciencecluster.opendatahub.io","controllerKind":"DataScienceCluster","DataScienceCluster":{"name":"e2e-test-dsc"},"namespace":"","name":"e2e-test-dsc","reconcileID":"23eb585a-2fe2-400a-8684-4c180e9d1365"}
{"level":"info","ts":"2025-01-18T20:51:57Z","logger":"features","msg":"waiting for resource to be created","feature":"serverless-serving-gateways","namespace":"knative-serving","resource":"operator.knative.dev/v1beta1, Kind=KnativeServing"}
{"level":"info","ts":"2025-01-18T20:51:59Z","logger":"features","msg":"resource created","feature":"serverless-serving-gateways","namespace":"knative-serving","resource":"operator.knative.dev/v1beta1, Kind=KnativeServing"}
{"level":"error","ts":"2025-01-18T20:51:59Z","msg":"Failed to execute action","controller":"kserve","controllerGroup":"components.platform.opendatahub.io","controllerKind":"Kserve","Kserve":{"name":"default-kserve"},"namespace":"","name":"default-kserve","reconcileID":"8559c8fc-c24f-4ebe-bf82-0f9ffa039045","action":"github.com/opendatahub-io/opendatahub-operator/v2/controllers/components/kserve.configureServerless","error":"2 errors occurred:\n\t* failed applying FeatureHandler features. cause: 1 error occurred:\n\t* 1 error occurred:\n\t* existing KNativeServing resource was found; integrating to an existing installation is not supported\n\n\n\n\n\t* failed applying FeatureHandler features. cause: 1 error occurred:\n\t* 1 error occurred:\n\t* context deadline exceeded\n\n\n\n\n\n}
{"level":"info","ts":"2025-01-18T20:51:59Z","msg":"reconcile","controller":"kserve","controllerGroup":"components.platform.opendatahub.io","controllerKind":"Kserve","Kserve":{"name":"default-kserve"},"namespace":"","name":"default-kserve","reconcileID":"89fb270d-7ab2-49a2-92b8-b2dc2ac8f22d"}

Adding some log to figure out what's going on

[lburgazzoli]

It may be caused by the order of testing, is modelcontroller tests are executed before, maybe the KNativeServing is left on the cluster. Adding a temporary cleanup logic also as part of the kserve test suite

[lburgazzoli]

/test opendatahub-operator-e2e