Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: remove Authorino patch for ossm #1513

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zdtsw
Copy link
Member

@zdtsw zdtsw commented Jan 17, 2025

this PR is depending on new Authorino release which must have Kuadrant/authorino-operator#236 or similar fix includeded first.

  • no need to patch servicemesh sidecar into Authorino deployment
  • add label directly on Authorino CR should auto pass to its pod

Description

How Has This Been Tested?

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

- no need to patch servicemesh sidecar into Authorino deployment
- add label directly on Authorino CR should auto pass to its pod

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
Copy link

openshift-ci bot commented Jan 17, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

openshift-ci bot commented Jan 17, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from zdtsw. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zdtsw zdtsw changed the title update: remove Authorino patch we did in the past update: remove Authorino patch for ossm Jan 17, 2025
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 20.01%. Comparing base (e6235d4) to head (eff752f).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1513      +/-   ##
==========================================
+ Coverage   19.78%   20.01%   +0.22%     
==========================================
  Files         160      160              
  Lines       10880    10863      -17     
==========================================
+ Hits         2153     2174      +21     
+ Misses       8500     8461      -39     
- Partials      227      228       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bartoszmajsak
Copy link
Contributor

You might want to handle the upgrade path as well - cleaning up the orphaned FeatureTracker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

2 participants