-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Go version in go.mod to 1.22 (Go 1.22: 2/3) #1439
Conversation
/hold wait for #1424 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1439 +/- ##
=======================================
Coverage ? 19.71%
=======================================
Files ? 149
Lines ? 10052
Branches ? 0
=======================================
Hits ? 1982
Misses ? 7846
Partials ? 224 ☔ View full report in Codecov by Sentry. |
JIRA: https://issues.redhat.com/browse/RHOAIENG-16819 The UBI8 go-toolset image that we use for building is already on 1.22, so I don't think there's any reason to remain bound to 1.21. Also, upstream Go only support the two most recent minor versions: currently that means 1.23 and 1.22; 1.21 is no longer receiving any updates from the Go developers.
JIRA: https://issues.redhat.com/browse/RHOAIENG-16819 This just updates the Go version in the go directive in go.mod. The code changes to add nolint suppression is temporary and those will be addressed in a separate commit.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ykaliuta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
5f456ad
into
opendatahub-io:main
* Update Dockerfiles to Go 1.22 JIRA: https://issues.redhat.com/browse/RHOAIENG-16819 The UBI8 go-toolset image that we use for building is already on 1.22, so I don't think there's any reason to remain bound to 1.21. Also, upstream Go only support the two most recent minor versions: currently that means 1.23 and 1.22; 1.21 is no longer receiving any updates from the Go developers. * Update Go version in go.mod to 1.22 JIRA: https://issues.redhat.com/browse/RHOAIENG-16819 This just updates the Go version in the go directive in go.mod. The code changes to add nolint suppression is temporary and those will be addressed in a separate commit. (cherry picked from commit 5f456ad)
* Update Dockerfiles to Go 1.22 (#1424) JIRA: https://issues.redhat.com/browse/RHOAIENG-16819 The UBI8 go-toolset image that we use for building is already on 1.22, so I don't think there's any reason to remain bound to 1.21. Also, upstream Go only support the two most recent minor versions: currently that means 1.23 and 1.22; 1.21 is no longer receiving any updates from the Go developers. * Update Go version in go.mod to 1.22 (Go 1.22: 2/3) (#1439) * Update Dockerfiles to Go 1.22 JIRA: https://issues.redhat.com/browse/RHOAIENG-16819 The UBI8 go-toolset image that we use for building is already on 1.22, so I don't think there's any reason to remain bound to 1.21. Also, upstream Go only support the two most recent minor versions: currently that means 1.23 and 1.22; 1.21 is no longer receiving any updates from the Go developers. * Update Go version in go.mod to 1.22 JIRA: https://issues.redhat.com/browse/RHOAIENG-16819 This just updates the Go version in the go directive in go.mod. The code changes to add nolint suppression is temporary and those will be addressed in a separate commit. (cherry picked from commit 5f456ad) * Specify full x.y.z version of Go in go.mod (#1442) JIRA: https://issues.redhat.com/browse/RHOAIENG-16819 It seems like on some platforms, when the local installation installation of Go decides that it needs to download a different toolchain, that it may fail unless we either specify a full x.y.z version in the `go` directive, or explicitly specify the `toolchain` directive. I believe for our uses, using a fully specified x.y.z `go` directive value is preferable, to prevent any issues with explicitly defining a toolchain where we might have a newer version in a container image build that has a default of `GOTOOLCHAIN='local'` (I'm not 100% sure if that would cause any issues, but I'm 100% sure that the way proposed in this commit shouldn't). (cherry picked from commit 79e1b94) * Address new linter errors introduced with Go 1.22 (#1440) JIRA: https://issues.redhat.com/browse/RHOAIENG-16819 (cherry picked from commit e30eb81) * fix: add nolint for loop Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: remove instead of skipping lint Signed-off-by: Wen Zhou <wenzhou@redhat.com> --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> Co-authored-by: Gerard Ryan <git@grdryn.xyz>
JIRA: https://issues.redhat.com/browse/RHOAIENG-16819
This PR is stacked upon #1424. That PR should be merged first.
Reviewstack may be a good way to review just the changes in this PR:
https://reviewstack.dev/opendatahub-io/opendatahub-operator/pull/1439
Description
This just updates the Go version in the go directive in go.mod. The code changes to add nolint suppression is temporary and those will be addressed in a separate commit.
How Has This Been Tested?
Screenshot or short clip
Merge criteria