[Sync]: incubation to rhoai #1405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test opendatahub-operator-e2e |
|
/test opendatahub-operator-e2e (different failure than previous attempt) |
fa8a34e to
f16c299
Compare
|
/test opendatahub-operator-e2e |
1 similar comment
|
/test opendatahub-operator-e2e |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## rhoai #1405 +/- ##
========================================
Coverage ? 18.87%
========================================
Files ? 30
Lines ? 3338
Branches ? 0
========================================
Hits ? 630
Misses ? 2639
Partials ? 69 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Wen Zhou <wenzhou@redhat.com> (cherry picked from commit 4a15a8f) Signed-off-by: Wen Zhou <wenzhou@redhat.com>
) The commit a107703 ("feat(fips): enable GO_ENABLED in build (opendatahub-io#1001)") enabled CGO which makes problems for builders on non-x86 platforms. Make it as an in the Dockerfile keeping default the same (enabled), but make it possible to override with either environment (`export CGO_ENABLED=0`) or make (`make CGO_ENABLED=0 image-build`) Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> (cherry picked from commit 2d94349)
Get USE_LOCAL image build flag from makefile variable to make it overridable with `make USE_LOCAL=true image` Do not allow to get its value for environment be default due to pretty generic name. This is shorter than the old recommendation of overriding IMAGE_BUILD_FLAGS. And since now CGO_ENABLED is also a flag, does not mess up with it. * USE_LOCAL=true uses existing manifests from opt/manifests for the produced image without downloading them with get_all_manifests.sh making it possible to both save time and make local amendments. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> (cherry picked from commit cea41dc)
We can combine two build stages into one, as there is no need to always build both images (not done by podman) to only then decide from which one we want to copy manifests to the target image. Instead manifests stage will either copy local manifests or fetches using the script based on USE_LOCAL argument. Move USE_LOCAL and OVERWIRTE_MANIFESTS args under FROM since args have scope of the FROM they are declared in. It requires opt/manifests directory to exist, but since it's a part of git repo, it's fine. Original patch from: Bartosz Majsak <bartosz.majsak@gmail.com> [1] [1] opendatahub-io#773 Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> (cherry picked from commit c1671ab)
- changes made in odh, missing manifests for rhoai since it is only using builder for main and others from manifests stage Signed-off-by: Wen Zhou <wenzhou@redhat.com>
|
/test ci-index |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: VaishnaviHire The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
bcfb033
into
opendatahub-io:rhoai
10 checks passed
MarianMacik
pushed a commit
to MarianMacik/opendatahub-operator
that referenced
this pull request
Jan 22, 2025
…flux/component-updates/odh-modelmesh-serving-controller-v2-17 chore(deps): update odh-modelmesh-serving-controller-v2-17 to abdc8dc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#1376
#1382
#1384
#1381
How Has This Been Tested?
Screenshot or short clip
Merge criteria