Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minKubeVersion to csv #139

Merged
merged 1 commit into from
Aug 23, 2021
Merged

Add minKubeVersion to csv #139

merged 1 commit into from
Aug 23, 2021

Conversation

VaishnaviHire
Copy link
Member

@VaishnaviHire VaishnaviHire commented Jul 1, 2021

This commit sets the minKubeVersion in csv to 1.18.0. This change prevents ODH operator from
being deployed on clusters with Kubernetes versions earlier than 1.18.0

Current supported versions of OpenShift: https://access.redhat.com/support/policy/updates/openshift#dates

Issue: https://issues.redhat.com/browse/ODH-414

@openshift-ci openshift-ci bot requested review from anishasthana and vpavlin July 1, 2021 17:27
@VaishnaviHire
Copy link
Member Author

/hold

@crobby
Copy link

crobby commented Jul 7, 2021

/test all

@LaVLaS
Copy link
Contributor

LaVLaS commented Jul 22, 2021

We added minKubeVersion to all of the opendatahub-operators CSVs in the community-operators repo. We need to sync those CSVs back to opendatahub-io because those CSVs also have the annotation olm.properties: '[{"type": "olm.maxOpenShiftVersion", "value": "4.8"}]'

From an offline discussion, the RH supported OCP is kubernetes 1.18.0 but we should be setting this to 1.16.0 for OCP 4.3 (or 4.2 w/ 1.14.0) even though they are end of life

@VaishnaviHire
Copy link
Member Author

We added minKubeVersion to all of the opendatahub-operators CSVs in the community-operators repo. We need to sync those CSVs back to opendatahub-io because those CSVs also have the annotation olm.properties: '[{"type": "olm.maxOpenShiftVersion", "value": "4.8"}]'

From an offline discussion, the RH supported OCP is kubernetes 1.18.0 but we should be setting this to 1.16.0 for OCP 4.3 (or 4.2 w/ 1.14.0) even though they are end of life

Yes I will update the version to 1.14?

How do we sync the CSVs? Do I need to open a separate PR?

This commit updates the operator csv to the latest version of community
operator v1.1.0
@nakfour nakfour self-assigned this Aug 19, 2021
@LaVLaS LaVLaS self-requested a review August 19, 2021 14:56
Copy link
Contributor

@LaVLaS LaVLaS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Aug 19, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LaVLaS, VaishnaviHire

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@LaVLaS
Copy link
Contributor

LaVLaS commented Aug 19, 2021

How do we sync the CSVs? Do I need to open a separate PR?

Just to provide a public answer for anyone else, the community-operators-prod repo is the source of truth for ODH operator in the OpenShift OperatorHub catalog. That standard release process is update/add the CSV here and then duplicate the change to prod. If any prod changes are made in that repo then we have to manually copy the entries back to this repo and commit the change

@VaishnaviHire
Copy link
Member Author

/test operator-e2e

@VaishnaviHire
Copy link
Member Author

/hold cancel

@openshift-merge-robot openshift-merge-robot merged commit b2be0bd into opendatahub-io:master Aug 23, 2021
VaishnaviHire pushed a commit to VaishnaviHire/opendatahub-operator that referenced this pull request Nov 28, 2023
* chore: removes log repetitions for conditions (opendatahub-io#762)

* update(knative): enable GPU node tolerations for kserve (opendatahub-io#761)

Signed-off-by: Wen Zhou <wenzhou@redhat.com>

---------

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
Co-authored-by: Bartosz Majsak <bartosz.majsak@gmail.com>
VaishnaviHire pushed a commit to VaishnaviHire/opendatahub-operator that referenced this pull request Nov 29, 2023
* chore: removes log repetitions for conditions (opendatahub-io#762)

* update(knative): enable GPU node tolerations for kserve (opendatahub-io#761)

Signed-off-by: Wen Zhou <wenzhou@redhat.com>

---------

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
Co-authored-by: Bartosz Majsak <bartosz.majsak@gmail.com>
(cherry picked from commit 0403062)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants