Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sync] fix: add extra check on servicemesh CRD and svc before proceeding create SMCP CR (#1359) #1367

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

zdtsw
Copy link
Member

@zdtsw zdtsw commented Nov 12, 2024

  • fix: add extra check on servicemesh CRD and service before proceeding create SMCP CR
  • when we install operator we might have a race condition:
    • ossm is not ready to server
    • dsci already created smcp CR
    • since we do not know the version of smcp to use
    • ossm webhook can run into conversion problem since no version specify in smcp CR
    • test: add more negative test
      • when CRD does not exist
      • when service does not exist

Signed-off-by: Wen Zhou wenzhou@redhat.com
(cherry picked from commit e25487a)

Description

https://issues.redhat.com/browse/RHOAIENG-15227

How Has This Been Tested?

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

…ate SMCP CR (opendatahub-io#1359)

* feat: add extra check on servicemesh CRD and service before proceeding create SMCP CR

- when we install operator we might have a race condition:
    - ossm is not ready to server
    - dsci already created smcp CR
    - since we do not know the version of smcp to use
    - ossm webhook can run into conversion problem since no version specify in smcp CR
   -  test: add more negative test
       - when CRD does not exist
       - when service does not exist

Signed-off-by: Wen Zhou <wenzhou@redhat.com>

---------

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
(cherry picked from commit e25487a)
@zdtsw zdtsw added the rhoai label Nov 12, 2024
@zdtsw zdtsw requested review from VaishnaviHire and removed request for jackdelahunt November 12, 2024 10:06
Copy link
Member

@VaishnaviHire VaishnaviHire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Given this is already tested with gitops deployment

Copy link

openshift-ci bot commented Nov 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: VaishnaviHire

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 62ebc16 into opendatahub-io:rhoai Nov 15, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants