Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: support NewUpdatePodSecurityRoleBindingAction with multiple serviceaccounts #1358

Conversation

zdtsw
Copy link
Member

@zdtsw zdtsw commented Nov 8, 2024

Description

in modelmesh case, it need to pass in a bunch of SA
to extend the support for this case

How Has This Been Tested?

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

…rviceaccounts

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
Copy link

openshift-ci bot commented Nov 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lburgazzoli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Nov 8, 2024
Copy link

openshift-ci bot commented Nov 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lburgazzoli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zdtsw zdtsw removed the request for review from Sara4994 November 8, 2024 10:28
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (feature-operator-refactor@f941791). Learn more about missing BASE report.

Files with missing lines Patch % Lines
pkg/controller/actions/security/actions.go 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                     Coverage Diff                      @@
##             feature-operator-refactor    #1358   +/-   ##
============================================================
  Coverage                             ?   24.45%           
============================================================
  Files                                ?       53           
  Lines                                ?     4294           
  Branches                             ?        0           
============================================================
  Hits                                 ?     1050           
  Misses                               ?     3113           
  Partials                             ?      131           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@openshift-merge-bot openshift-merge-bot bot merged commit 10197da into opendatahub-io:feature-operator-refactor Nov 8, 2024
10 checks passed
MarianMacik pushed a commit to MarianMacik/opendatahub-operator that referenced this pull request Jan 22, 2025
…flux/component-updates/odh-ml-pipelines-persistenceagent-v2-v2-17

chore(deps): update odh-ml-pipelines-persistenceagent-v2-v2-17 to 7cb03a3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants