feat: add support for modelmeshserving as component #1338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6694329 to
d862434
Compare
|
/test opendatahub-operator-e2e |
cb90c62 to
a833dd5
Compare
grdryn
reviewed
Nov 12, 2024
apis/components/v1/kserve_types.go
Outdated
| @@ -21,6 +21,10 @@ import ( | |||
| metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | |||
| ) | |||
|
|
|||
| const ( | |||
| ModelMeshCtrlerComponentName = "odh-model-controller" // shared by kserve and mm | |||
There was a problem hiding this comment.
Suggested change
| ModelMeshCtrlerComponentName = "odh-model-controller" // shared by kserve and mm | |
| ModelControllerComponentName = "odh-model-controller" // shared by kserve and mm |
I assume that it shouldn't have ModelMesh in the name if it's not modelmesh specific?
f2ae263 to
206adab
Compare
2fbf65d to
f84aa91
Compare
- add new modelcontroller component: do not show in DSC.status.installedComponents - e2e on modelcontroller wont run in parallel but after components are done - if modelmesh is enabled and/or kserve is enabled, modelcontroller should be created - devFlag for modelcontroller from kserve (high) or modelmesh (low) priority - set dynamic watch on kserve and modelmesh because one of them might enabled later - reuse the same clusterrole from kserve on aggregated rules - add kserve and/or modelmesh into ownerrefence but not set as controller, keep DSC for now Signed-off-by: Wen Zhou <wenzhou@redhat.com>
Signed-off-by: Wen Zhou <wenzhou@redhat.com>
…nd modelmesh - kserve inject itself as owner to modelcontroller - modelmesh inject iteslef as owner to modelcontroller - modelcontroller no need to watch kserve nor modelmesh - removed duplicated check in dsc for "enabled" which is in the GetManagementStatus Signed-off-by: Wen Zhou <wenzhou@redhat.com>
- fix installedComponent map to not include modelcontroller - to not add old kserve UID when new kserve CR created(if in any case, kserve CR is deleted but UID remain in modelcontroller) - ditto to modelmeshserving - add .status.uri to set exactly which uri is used for devflag if devFlags is set overwrite odh-model-controller - to explicitly show .spec.kserve.managementstate and .spec.modelmeshserving.managementstate in modelcontroller Signed-off-by: Wen Zhou <wenzhou@redhat.com>
- till we know more what we want to do, we keep modelcontroller ownereference to only DSC Signed-off-by: Wen Zhou <wenzhou@redhat.com>
- both kserve and mdoelmesh ship these 2 CRDs Signed-off-by: Wen Zhou <wenzhou@redhat.com>
- will update with new function on CRD later Signed-off-by: Wen Zhou <wenzhou@redhat.com>
Signed-off-by: Wen Zhou <wenzhou@redhat.com>
|
LGTM, @VaishnaviHire ? |
VaishnaviHire
approved these changes
Dec 4, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: VaishnaviHire The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
New changes are detected. LGTM label has been removed. |
2aff8dc
into
opendatahub-io:feature-operator-refactor
6 of 8 checks passed
This was referenced Dec 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
should have kserve and/or modelmeshserving as ownerrefence if they are enabled but keep DSC as controller for nowhttps://issues.redhat.com/browse/RHOAIENG-15481
https://issues.redhat.com/browse/RHOAIENG-13177
How Has This Been Tested?
Screenshot or short clip
Merge criteria