Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create ModelRegistry component API and reconciler #1337

Merged
merged 5 commits into from
Nov 5, 2024
Merged

Create ModelRegistry component API and reconciler #1337

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f486365
Create ModelRegistry component API and reconciler
lburgazzoli Oct 31, 2024
c0338c9
Create ModelRegistry component API and reconciler (ssa)
lburgazzoli Nov 4, 2024
6e74e0a
Create ModelRegistry component API and reconciler (findings)
lburgazzoli Nov 4, 2024
5f888da
Update modelregistry_controller_actions.go
lburgazzoli Nov 4, 2024
40e6053
Create ModelRegistry component API and reconciler (findings)
lburgazzoli Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update modelregistry_controller_actions.go 
Co-authored-by: Gerard Ryan <git@grdryn.xyz>
  • Loading branch information
@lburgazzoli @grdryn
lburgazzoli and grdryn committed Nov 5, 2024
commit 5f888dadf103a981bb1ba6d2e186bfd1c317115d
2 changes: 1 addition & 1 deletion controllers/components/modelregistry/modelregistry_controller_actions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ const (
func gate(_ context.Context, rr *odhtypes.ReconciliationRequest) error {
mr, ok := rr.Instance.(*componentsv1.ModelRegistry)
if !ok {
return fmt.Errorf("resource instance %v is not a ResourceObject", rr.Instance)
return fmt.Errorf("resource instance %v is not a componentsv1.ModelRegistry", rr.Instance)
}

if rr.DSCI.Spec.ServiceMesh != nil && rr.DSCI.Spec.ServiceMesh.ManagementState == operatorv1.Managed {
Expand Down
Loading