Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for kueue component #1333

Conversation

zdtsw
Copy link
Member

@zdtsw zdtsw commented Oct 31, 2024

  • add kueue for component
  • move kueue's rbac to dsc's kubebuilder_rback.go
  • make DSC as const in test, fix lint

Description

https://issues.redhat.com/browse/RHOAIENG-13180

How Has This Been Tested?

quay.io/wenzhou/opendatahub-operator-catalog:v2.16.13180-3

  • create DSC and set kueue to Managed
  • check installedComponent has kueue:true
  • check default-kueue is created, spec {} status set to ready
  • check kueue pod is running, podmonitori is created, both has default-kueue as owner
  • update DSC and set kueue to Removed
  • check installedComponent has kueue:false
  • default-kueue and pod + podmonitor are all removed

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Please upload report for BASE (feature-operator-refactor@1209501). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...atasciencecluster/datasciencecluster_controller.go 0.00% 7 Missing ⚠️
Additional details and impacted files
@@                     Coverage Diff                      @@
##             feature-operator-refactor    #1333   +/-   ##
============================================================
  Coverage                             ?   25.80%           
============================================================
  Files                                ?       55           
  Lines                                ?     4395           
  Branches                             ?        0           
============================================================
  Hits                                 ?     1134           
  Misses                               ?     3122           
  Partials                             ?      139           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zdtsw zdtsw force-pushed the jira/13180 branch 2 times, most recently from b083169 to 81099a4 Compare November 2, 2024 15:34
@lburgazzoli
Copy link
Contributor

LGTM, @VaishnaviHire for final review

Copy link
Member

@VaishnaviHire VaishnaviHire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@zdtsw zdtsw force-pushed the jira/13180 branch 4 times, most recently from 56cfeed to d212f91 Compare November 8, 2024 11:35
Signed-off-by: Wen Zhou <wenzhou@redhat.com>
Copy link

openshift-ci bot commented Nov 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lburgazzoli, VaishnaviHire

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [VaishnaviHire,lburgazzoli]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit d96d039 into opendatahub-io:feature-operator-refactor Nov 12, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants