fix(crd): adds validation pattern and max length for ns fields #1261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c1419ab to
eb4ee35
Compare
zdtsw
approved these changes
Sep 25, 2024
This commit introduces a validation pattern and maximum length constraint to the `Namespace` fields in our structs. We have missed it in the early days. Validation rules ensure that namespace names does not exceed max length defined and are valid [RFC 1123 DNS labels](https://kubernetes.io/docs/concepts/overview/working-with-objects/namespaces/#namespaces-and-dns).
eb4ee35 to
15922a4
Compare
zdtsw
approved these changes
Sep 25, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zdtsw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
5648ee9
into
opendatahub-io:incubation
8 checks passed
5 tasks
zdtsw
referenced
this pull request
in zdtsw-forking/rhods-operator
Oct 10, 2024
…at-data-services#1261) This commit introduces a validation pattern and maximum length constraint to the `Namespace` fields in our structs. We have missed it in the early days. Validation rules ensure that namespace names does not exceed max length defined and are valid [RFC 1123 DNS labels](https://kubernetes.io/docs/concepts/overview/working-with-objects/namespaces/#namespaces-and-dns). (cherry picked from commit 5648ee9)
5 tasks
zdtsw
referenced
this pull request
in red-hat-data-services/rhods-operator
Oct 17, 2024
* fix(crd): adds validation pattern and max length for ns fields (#1261) This commit introduces a validation pattern and maximum length constraint to the `Namespace` fields in our structs. We have missed it in the early days. Validation rules ensure that namespace names does not exceed max length defined and are valid [RFC 1123 DNS labels](https://kubernetes.io/docs/concepts/overview/working-with-objects/namespaces/#namespaces-and-dns). (cherry picked from commit 5648ee9) * update: add validation on application and monitoring namespace in DSCI (#1263) Signed-off-by: Wen Zhou <wenzhou@redhat.com> (cherry picked from commit 0f382d5) --------- Co-authored-by: Bartosz Majsak <bartosz.majsak@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit introduces a validation pattern and maximum length constraint to the
Namespacefields in our structs. We have missed it in the early days.Validation rules ensure that namespace names does not exceed max length defined and are valid RFC 1123 DNS labels.
How Has This Been Tested?
Screenshot or short clip
Merge criteria