Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename GetPlatform functions to not reflect implementation #1232

Merged

Conversation

ykaliuta
Copy link
Contributor

GetReleaseFromCSV name is more about implementation than the task it
performs. The function fetches actual running operator release and
CSV is only one possibility for that.

GetReleaseFromCR name is more about implementation than the task it
performs. The function fetches release from DSC/DSCI mean the latest
release the data science cluster was deployed by. Consider it as
"deployed release".

Description

How Has This Been Tested?

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

GetReleaseFromCR name is more about implementation than the task it
performs. The function fetches release from DSC/DSCI mean the latest
release the data science cluster was deployed by. Consider it as
"deployed release".

Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com>
GetReleaseFromCSV name is more about implementation than the task it
performs. The function fetches actual running operator release and
CSV is only one possibility for that.

Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com>
@ykaliuta
Copy link
Contributor Author

/cc @zdtsw @lburgazzoli

@openshift-ci openshift-ci bot requested review from lburgazzoli and zdtsw September 13, 2024 11:19
@ykaliuta
Copy link
Contributor Author

/test opendatahub-operator-e2e

Copy link

openshift-ci bot commented Sep 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lburgazzoli, zdtsw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zdtsw zdtsw added the odh-2.18 label Sep 13, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit b4c880a into opendatahub-io:incubation Sep 13, 2024
8 checks passed
zdtsw referenced this pull request in zdtsw-forking/rhods-operator Sep 16, 2024
…ata-services#1232)

* upgrade: rename GetReleaseFromCR to GetDeployedRelease

GetReleaseFromCR name is more about implementation than the task it
performs. The function fetches release from DSC/DSCI mean the latest
release the data science cluster was deployed by. Consider it as
"deployed release".

Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com>

* cluster: rename GetReleaseFromCSV back to GetRelease

GetReleaseFromCSV name is more about implementation than the task it
performs. The function fetches actual running operator release and
CSV is only one possibility for that.

Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com>

---------

Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com>
(cherry picked from commit b4c880a)
VaishnaviHire pushed a commit to VaishnaviHire/opendatahub-operator that referenced this pull request Sep 16, 2024
…ub-io#1232)

* upgrade: rename GetReleaseFromCR to GetDeployedRelease

GetReleaseFromCR name is more about implementation than the task it
performs. The function fetches release from DSC/DSCI mean the latest
release the data science cluster was deployed by. Consider it as
"deployed release".

Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com>

* cluster: rename GetReleaseFromCSV back to GetRelease

GetReleaseFromCSV name is more about implementation than the task it
performs. The function fetches actual running operator release and
CSV is only one possibility for that.

Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com>

---------

Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com>
(cherry picked from commit b4c880a)
VaishnaviHire pushed a commit to VaishnaviHire/opendatahub-operator that referenced this pull request Sep 16, 2024
…ub-io#1232)

* upgrade: rename GetReleaseFromCR to GetDeployedRelease

GetReleaseFromCR name is more about implementation than the task it
performs. The function fetches release from DSC/DSCI mean the latest
release the data science cluster was deployed by. Consider it as
"deployed release".

Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com>

* cluster: rename GetReleaseFromCSV back to GetRelease

GetReleaseFromCSV name is more about implementation than the task it
performs. The function fetches actual running operator release and
CSV is only one possibility for that.

Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com>

---------

Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com>
(cherry picked from commit b4c880a)
openshift-merge-bot bot referenced this pull request in red-hat-data-services/rhods-operator Sep 18, 2024
* upgrade: rename GetReleaseFromCR to GetDeployedRelease

GetReleaseFromCR name is more about implementation than the task it
performs. The function fetches release from DSC/DSCI mean the latest
release the data science cluster was deployed by. Consider it as
"deployed release".

Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com>

* cluster: rename GetReleaseFromCSV back to GetRelease

GetReleaseFromCSV name is more about implementation than the task it
performs. The function fetches actual running operator release and
CSV is only one possibility for that.

Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com>

---------

Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com>
(cherry picked from commit b4c880a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants