Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cache): since we add new secret from modelreg with cache, we need to lose the cache for istio-system ns #1223

Merged

Conversation

zdtsw
Copy link
Member

@zdtsw zdtsw commented Sep 5, 2024

Description

it is causing problem in modelreg with reconcile in Operator pod
related to #1190

How Has This Been Tested?

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

… to lose the cache for istio-system ns

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
@zdtsw zdtsw requested a review from bartoszmajsak September 5, 2024 12:37
@zdtsw zdtsw requested review from lburgazzoli and removed request for adelton September 5, 2024 12:49
@zdtsw
Copy link
Member Author

zdtsw commented Sep 5, 2024

1 node(s) had untolerated taint {node-role.kubernetes.io/ci-builds-worker: ci-builds-worker}, 13 node(s) were unschedulable, 3 node(s) had untolerated taint {node-role.kubernetes.io/infra: }, 3 node(s) had untolerated taint {node-role.kubernetes.io/master: }, 6 node(s) didn't match Pod's node affinity/selector. no new claims to deallocate, preemption: 0/26 nodes are available: 26 Preemption is not helpful for scheduling..................

@zdtsw
Copy link
Member Author

zdtsw commented Sep 5, 2024

/retest

1 similar comment
@zdtsw
Copy link
Member Author

zdtsw commented Sep 5, 2024

/retest

Copy link
Member

@VaishnaviHire VaishnaviHire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Sep 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: VaishnaviHire

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Sep 5, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit c49b501 into opendatahub-io:incubation Sep 5, 2024
8 checks passed
VaishnaviHire pushed a commit to VaishnaviHire/opendatahub-operator that referenced this pull request Sep 16, 2024
… to lose the cache for istio-system ns (opendatahub-io#1223)

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
(cherry picked from commit c49b501)
VaishnaviHire pushed a commit to VaishnaviHire/opendatahub-operator that referenced this pull request Sep 16, 2024
… to lose the cache for istio-system ns (opendatahub-io#1223)

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
(cherry picked from commit c49b501)
openshift-merge-bot bot referenced this pull request in red-hat-data-services/rhods-operator Sep 18, 2024
… to lose the cache for istio-system ns (#1223)

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
(cherry picked from commit c49b501)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants