-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: e2e: testApplicationCreation cleanup #1215
Merged
openshift-merge-bot
merged 4 commits into
opendatahub-io:incubation
from
ykaliuta:e2e-appcreate-cleanup
Sep 3, 2024
Merged
tests: e2e: testApplicationCreation cleanup #1215
openshift-merge-bot
merged 4 commits into
opendatahub-io:incubation
from
ykaliuta:e2e-appcreate-cleanup
Sep 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The message is misleading, actually it returns error so will not retry. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com>
…ntextTimeout After recent update the check was moved after DSC Ready check. There is no point to wait extra Retry Interval for deployment check. It decreases execution time. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com>
The intention for the check originally was to return success if no deployments for component found due to missing operator (probably with a bug in actual check). Anyway, the case is not valid anymore, dependent operators are installed. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com>
Simplify deployments readiness check loop with early return when problematic deployment found and successful return as the default. The len() == 0 check is needed otherwise it will declare success for no deployements. It will be amended with enabled/disabled check in a followup. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com>
/cc @zdtsw |
zdtsw
approved these changes
Sep 3, 2024
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zdtsw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit Sep 3, 2024
fc005e3
into
opendatahub-io:incubation
8 checks passed
zdtsw
referenced
this pull request
in zdtsw-forking/rhods-operator
Sep 11, 2024
* tests: e2e: do not print Trying again if cannot list deployments The message is misleading, actually it returns error so will not retry. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> * tests: e2e: testApplicationCreation: enable immediate for PollUntilContextTimeout After recent update the check was moved after DSC Ready check. There is no point to wait extra Retry Interval for deployment check. It decreases execution time. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> * tests: e2e: remove check for dependent operator The intention for the check originally was to return success if no deployments for component found due to missing operator (probably with a bug in actual check). Anyway, the case is not valid anymore, dependent operators are installed. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> * tests: e2e: testApplicationCreation: early return from the loop Simplify deployments readiness check loop with early return when problematic deployment found and successful return as the default. The len() == 0 check is needed otherwise it will declare success for no deployements. It will be amended with enabled/disabled check in a followup. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> --------- Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> (cherry picked from commit fc005e3)
openshift-merge-bot bot
referenced
this pull request
in red-hat-data-services/rhods-operator
Sep 12, 2024
* tests: e2e: do not print Trying again if cannot list deployments The message is misleading, actually it returns error so will not retry. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> * tests: e2e: testApplicationCreation: enable immediate for PollUntilContextTimeout After recent update the check was moved after DSC Ready check. There is no point to wait extra Retry Interval for deployment check. It decreases execution time. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> * tests: e2e: remove check for dependent operator The intention for the check originally was to return success if no deployments for component found due to missing operator (probably with a bug in actual check). Anyway, the case is not valid anymore, dependent operators are installed. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> * tests: e2e: testApplicationCreation: early return from the loop Simplify deployments readiness check loop with early return when problematic deployment found and successful return as the default. The len() == 0 check is needed otherwise it will declare success for no deployements. It will be amended with enabled/disabled check in a followup. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> --------- Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> (cherry picked from commit fc005e3)
VaishnaviHire
pushed a commit
to VaishnaviHire/opendatahub-operator
that referenced
this pull request
Sep 16, 2024
* tests: e2e: do not print Trying again if cannot list deployments The message is misleading, actually it returns error so will not retry. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> * tests: e2e: testApplicationCreation: enable immediate for PollUntilContextTimeout After recent update the check was moved after DSC Ready check. There is no point to wait extra Retry Interval for deployment check. It decreases execution time. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> * tests: e2e: remove check for dependent operator The intention for the check originally was to return success if no deployments for component found due to missing operator (probably with a bug in actual check). Anyway, the case is not valid anymore, dependent operators are installed. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> * tests: e2e: testApplicationCreation: early return from the loop Simplify deployments readiness check loop with early return when problematic deployment found and successful return as the default. The len() == 0 check is needed otherwise it will declare success for no deployements. It will be amended with enabled/disabled check in a followup. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> --------- Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> (cherry picked from commit fc005e3)
VaishnaviHire
pushed a commit
to VaishnaviHire/opendatahub-operator
that referenced
this pull request
Sep 16, 2024
* tests: e2e: do not print Trying again if cannot list deployments The message is misleading, actually it returns error so will not retry. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> * tests: e2e: testApplicationCreation: enable immediate for PollUntilContextTimeout After recent update the check was moved after DSC Ready check. There is no point to wait extra Retry Interval for deployment check. It decreases execution time. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> * tests: e2e: remove check for dependent operator The intention for the check originally was to return success if no deployments for component found due to missing operator (probably with a bug in actual check). Anyway, the case is not valid anymore, dependent operators are installed. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> * tests: e2e: testApplicationCreation: early return from the loop Simplify deployments readiness check loop with early return when problematic deployment found and successful return as the default. The len() == 0 check is needed otherwise it will declare success for no deployements. It will be amended with enabled/disabled check in a followup. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> --------- Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> (cherry picked from commit fc005e3)
openshift-merge-bot bot
referenced
this pull request
in red-hat-data-services/rhods-operator
Sep 18, 2024
* tests: e2e: do not print Trying again if cannot list deployments The message is misleading, actually it returns error so will not retry. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> * tests: e2e: testApplicationCreation: enable immediate for PollUntilContextTimeout After recent update the check was moved after DSC Ready check. There is no point to wait extra Retry Interval for deployment check. It decreases execution time. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> * tests: e2e: remove check for dependent operator The intention for the check originally was to return success if no deployments for component found due to missing operator (probably with a bug in actual check). Anyway, the case is not valid anymore, dependent operators are installed. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> * tests: e2e: testApplicationCreation: early return from the loop Simplify deployments readiness check loop with early return when problematic deployment found and successful return as the default. The len() == 0 check is needed otherwise it will declare success for no deployements. It will be amended with enabled/disabled check in a followup. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> --------- Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> (cherry picked from commit fc005e3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How Has This Been Tested?
Screenshot or short clip
Merge criteria