deps: uplift crd-ref-docs to 0.1.0 #1206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- their release changed and support different os/arch binary Signed-off-by: Wen Zhou <wenzhou@redhat.com>
ykaliuta
reviewed
Aug 27, 2024
Makefile
Outdated
| ARCH=x86_64 | ||
| else | ||
| ARCH=$(strip $(shell go env GOARCH)) | ||
| endif |
There was a problem hiding this comment.
Their OS and ARCH values are uname -s and uname -m
There was a problem hiding this comment.
i rewrite this whole shabnag
Makefile
Outdated
| test -s $(CRD_REF_DOCS) || curl -sSLo $(CRD_REF_DOCS) $(CRD_REF_DOCS_DL_URL) && \ | ||
| chmod +x $(CRD_REF_DOCS) ;\ | ||
| test -s $(CRD_REF_DOCS) || ( \ | ||
| OS=$(shell go env GOOS) && \ |
Makefile
Outdated
| OS=$(shell go env GOOS) && \ | ||
| wget -q -O $(LOCALBIN)/$(CRD_REF_DOCS_TARBALL) https://github.com/elastic/crd-ref-docs/releases/download/v$(CRD_REF_DOCS_VERSION)/crd-ref-docs_$(CRD_REF_DOCS_VERSION)_$${OS}_${ARCH}.tar.gz && \ | ||
| tar -xzf $(LOCALBIN)/$(CRD_REF_DOCS_TARBALL) -C $(LOCALBIN) && \ | ||
| rm -rf $(LOCALBIN)/$(CRD_REF_DOCS_TARBALL) $(LOCALBIN)/LICENSE $(LOCALBIN)/README.md && \ |
There was a problem hiding this comment.
I would use something like
curl -sSL <tarball url> | tar -zxf - -C $(LOCALBIN) crd-ref-docs
Makefile
Outdated
| chmod +x $(CRD_REF_DOCS) ;\ | ||
| test -s $(CRD_REF_DOCS) || ( \ | ||
| OS=$(shell go env GOOS) && \ | ||
| wget -q -O $(LOCALBIN)/$(CRD_REF_DOCS_TARBALL) https://github.com/elastic/crd-ref-docs/releases/download/v$(CRD_REF_DOCS_VERSION)/crd-ref-docs_$(CRD_REF_DOCS_VERSION)_$${OS}_${ARCH}.tar.gz && \ |
There was a problem hiding this comment.
$() for make variables please
|
amd64 is a legacy name from the times when Intel did not support it and promoted their VLIW IA64. Debian keeps it the same for the same reasons. But nowadays name is x86_64. |
ykaliuta
reviewed
Aug 27, 2024
Makefile
Outdated
| chmod +x $(CRD_REF_DOCS) ;\ | ||
| test -s $(CRD_REF_DOCS) || ( \ | ||
| curl -sSL https://github.com/elastic/crd-ref-docs/releases/download/v$(CRD_REF_DOCS_VERSION)/crd-ref-docs_$(CRD_REF_DOCS_VERSION)_$(shell uname -s)_$(shell uname -m).tar.gz | tar -xzf - -C $(LOCALBIN) && \ | ||
| rm -rf $(LOCALBIN)/LICENSE $(LOCALBIN)/README.md && \ |
There was a problem hiding this comment.
I would put filename to tar to extract (as in my example), then you do not need to rm anything.
Makefile
Outdated
| test -s $(CRD_REF_DOCS) || curl -sSLo $(CRD_REF_DOCS) $(CRD_REF_DOCS_DL_URL) && \ | ||
| chmod +x $(CRD_REF_DOCS) ;\ | ||
| test -s $(CRD_REF_DOCS) || ( \ | ||
| curl -sSL https://github.com/elastic/crd-ref-docs/releases/download/v$(CRD_REF_DOCS_VERSION)/crd-ref-docs_$(CRD_REF_DOCS_VERSION)_$(shell uname -s)_$(shell uname -m).tar.gz | tar -xzf - -C $(LOCALBIN) && \ |
There was a problem hiding this comment.
I do not have strong opinion, usually I would put that in variables, then the names are self descriptive. But this will work as well.
Signed-off-by: Wen Zhou <wenzhou@redhat.com>
ykaliuta
approved these changes
Aug 27, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ykaliuta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3ce4d58
into
opendatahub-io:incubation
8 checks passed
zdtsw
referenced
this pull request
in zdtsw-forking/rhods-operator
Aug 29, 2024
* deps: uplift crd-ref-docs to 0.1.0 - their release changed and support different os/arch binary Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: rewrite after review Signed-off-by: Wen Zhou <wenzhou@redhat.com> --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> (cherry picked from commit 3ce4d58)
openshift-merge-bot bot
referenced
this pull request
in red-hat-data-services/rhods-operator
Aug 30, 2024
* deps: uplift crd-ref-docs to 0.1.0 - their release changed and support different os/arch binary Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: rewrite after review Signed-off-by: Wen Zhou <wenzhou@redhat.com> --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> (cherry picked from commit 3ce4d58)
VaishnaviHire
pushed a commit
to VaishnaviHire/opendatahub-operator
that referenced
this pull request
Sep 16, 2024
* deps: uplift crd-ref-docs to 0.1.0 - their release changed and support different os/arch binary Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: rewrite after review Signed-off-by: Wen Zhou <wenzhou@redhat.com> --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> (cherry picked from commit 3ce4d58)
VaishnaviHire
pushed a commit
to VaishnaviHire/opendatahub-operator
that referenced
this pull request
Sep 16, 2024
* deps: uplift crd-ref-docs to 0.1.0 - their release changed and support different os/arch binary Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: rewrite after review Signed-off-by: Wen Zhou <wenzhou@redhat.com> --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> (cherry picked from commit 3ce4d58)
openshift-merge-bot bot
referenced
this pull request
in red-hat-data-services/rhods-operator
Sep 18, 2024
* deps: uplift crd-ref-docs to 0.1.0 - their release changed and support different os/arch binary Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: rewrite after review Signed-off-by: Wen Zhou <wenzhou@redhat.com> --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> (cherry picked from commit 3ce4d58)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How Has This Been Tested?
Screenshot or short clip
Merge criteria