Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add operator namespace variable for unit-test #1204

Merged

Conversation

zdtsw
Copy link
Member

@zdtsw zdtsw commented Aug 26, 2024

Description

follow up: #1201 (comment)

How Has This Been Tested?

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
@openshift-ci openshift-ci bot requested review from grdryn and jackdelahunt August 26, 2024 09:23
@zdtsw zdtsw requested review from lburgazzoli and mwaykole and removed request for grdryn and jackdelahunt August 26, 2024 09:23
Copy link

openshift-ci bot commented Aug 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lburgazzoli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 843e7e5 into opendatahub-io:incubation Aug 26, 2024
8 checks passed
zdtsw referenced this pull request in zdtsw-forking/rhods-operator Aug 29, 2024
…vices#1204)

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
(cherry picked from commit 843e7e5)
openshift-merge-bot bot referenced this pull request in red-hat-data-services/rhods-operator Aug 30, 2024
Signed-off-by: Wen Zhou <wenzhou@redhat.com>
(cherry picked from commit 843e7e5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants