Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Rework release automation - || #1199

Merged

Conversation

AjayJagan
Copy link
Contributor

@AjayJagan AjayJagan commented Aug 22, 2024

Description

The following changes are added

  • Allow the tracker URL to support adding tags ie.
    • If a component has both tag and branch as the same value then the tracker can be updated as component_name|branch-or-tag-url
    • If a component has different tag and branch values, the the tracker can be updated as
      component_name|branch-or-tag-url|release-notes-url
  • Remove wait for checks for the version update pr as we can manually verify the checks and merge(This merge will trigger the next set of gh actions)
  • Improve grouping in the release notes. eg: Under "Serving" heading we should have the notes of Modelmesh, odh-model-controller etc
  • Fix skopeo login issue

How Has This Been Tested?

Tested in my repo:
https://github.com/AjayJagan/opendatahub-operator/actions/runs/10501974699
https://github.com/AjayJagan/opendatahub-operator/actions/runs/10502024580

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

The following changes are added
- Remove wait for checks for the version update pr as we can manually verify the checks and merge(This merge will trigger the next set of gh actions)
- Improve grouping in the release notes. eg: Under "Serving" heading we should have the notes of Modelmesh, odh-model-controller etc
- Fix skopeo login issue
- Allow the tracker URL to support adding tags ie.
  - If a component has both tag and branch as the same value then the tracker can be updated as component_name|branch-or-tag-url
  - If a component has different tag and branch values, the the tracker can be updated as
    component_name|branch-or-tag-url|release-notes/tag-url
@AjayJagan AjayJagan force-pushed the rework-automation-2 branch from f8e65a2 to 3e6c46a Compare August 22, 2024 07:37
@AjayJagan
Copy link
Contributor Author

@VaishnaviHire ^

Copy link
Member

@VaishnaviHire VaishnaviHire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Sep 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: VaishnaviHire

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Sep 4, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit d0c1d5e into opendatahub-io:incubation Sep 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants