Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: uplift controller_gen and envtest version #1198

Merged

Conversation

zdtsw
Copy link
Member

@zdtsw zdtsw commented Aug 22, 2024

Description

  • regenerate code and manifests
  • controller gen from 0.9.2 to 0.16.1
  • envtest from 1.24.2 to 1.31.0 (1.31.0 was released with controll gen 0.16.0) , binary new pinned version
  • new external crds downloaded

How Has This Been Tested?

make clean
make default

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@zdtsw zdtsw requested a review from bartoszmajsak August 22, 2024 07:07
@zdtsw zdtsw changed the title deps: uplift controller_gen and envtets version deps: uplift controller_gen and envtest version Aug 22, 2024
- regenerate code and manifests
- checkin new external crd

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
Copy link
Contributor

@bartoszmajsak bartoszmajsak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't harm to bring latest and the greatest, but I leave a final say to other reviewers :)

One could argue that controller_gen and envtest are not really related, but I assume newer version of the former needs bump of the latter?

@zdtsw
Copy link
Member Author

zdtsw commented Aug 23, 2024

Won't harm to bring latest and the greatest, but I leave a final say to other reviewers :)

One could argue that controller_gen and envtest are not really related, but I assume newer version of the former needs bump of the latter?

controller gen should be the latest and hottest one, https://github.com/kubernetes-sigs/controller-tools/releases/tag/v0.16.1
envtest 1.31.0 acutally was released with controller gen 0.16.0

@zdtsw zdtsw requested a review from ykaliuta August 26, 2024 13:43
Copy link

openshift-ci bot commented Aug 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ykaliuta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 1f34806 into opendatahub-io:incubation Aug 26, 2024
8 checks passed
VaishnaviHire pushed a commit to VaishnaviHire/opendatahub-operator that referenced this pull request Sep 16, 2024
- regenerate code and manifests
- checkin new external crd

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
(cherry picked from commit 1f34806)
VaishnaviHire pushed a commit to VaishnaviHire/opendatahub-operator that referenced this pull request Sep 16, 2024
- regenerate code and manifests
- checkin new external crd

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
(cherry picked from commit 1f34806)
openshift-merge-bot bot referenced this pull request in red-hat-data-services/rhods-operator Sep 18, 2024
- regenerate code and manifests
- checkin new external crd

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
(cherry picked from commit 1f34806)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants