-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: uplift controller_gen and envtest version #1198
deps: uplift controller_gen and envtest version #1198
Conversation
- regenerate code and manifests - checkin new external crd Signed-off-by: Wen Zhou <wenzhou@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't harm to bring latest and the greatest, but I leave a final say to other reviewers :)
One could argue that controller_gen and envtest are not really related, but I assume newer version of the former needs bump of the latter?
controller gen should be the latest and hottest one, https://github.com/kubernetes-sigs/controller-tools/releases/tag/v0.16.1 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ykaliuta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1f34806
into
opendatahub-io:incubation
- regenerate code and manifests - checkin new external crd Signed-off-by: Wen Zhou <wenzhou@redhat.com> (cherry picked from commit 1f34806)
- regenerate code and manifests - checkin new external crd Signed-off-by: Wen Zhou <wenzhou@redhat.com> (cherry picked from commit 1f34806)
- regenerate code and manifests - checkin new external crd Signed-off-by: Wen Zhou <wenzhou@redhat.com> (cherry picked from commit 1f34806)
Description
How Has This Been Tested?
Screenshot or short clip
Merge criteria