kserve: do not call ApplyParams for the empty list #1179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zdtsw
approved these changes
Aug 15, 2024
thanks for the fix, it is introduced without intention.after offline discussion, we realized this caller is not necessary at all. |
The call is not need since the code just declare empty parameters
list:
var imageParamMap = map[string]string{}
Fixes the issue of calling ApplyParams for non-enabled case.
Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com>
49d5cd4 to
41382ac
Compare
zdtsw
approved these changes
Aug 15, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zdtsw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required |
db144ed
into
opendatahub-io:incubation
8 checks passed
zdtsw
referenced
this pull request
in zdtsw-forking/rhods-operator
Aug 29, 2024
…ices#1179) The call is not need since the code just declare empty parameters list: var imageParamMap = map[string]string{} Fixes the issue of calling ApplyParams for non-enabled case. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> (cherry picked from commit db144ed)
openshift-merge-bot bot
referenced
this pull request
in red-hat-data-services/rhods-operator
Aug 29, 2024
The call is not need since the code just declare empty parameters
list:
var imageParamMap = map[string]string{}
Fixes the issue of calling ApplyParams for non-enabled case.
Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com>
(cherry picked from commit db144ed)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The call is not need since the code just declare empty parameters list:
var imageParamMap = map[string]string{}
Fixes the issue of calling ApplyParams for non-enabled case.
Credits-to: Wen Zhou wenzhou@redhat.com
Description
How Has This Been Tested?
Screenshot or short clip
Merge criteria