fix(feature): ensures all new resources are created in one reconcile #1159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manifests used by Feature to create cluster resources can be either defined as a single resource per file or grouped together and separated using the `---` delimiter. Even though the former approach is currently preferred across the codebase, the latter is used to create Envoy filters for the KServe setup. When applying resources not yet present in the cluster, the original implementation returns after creating the first resource, leaving the rest unprocessed. They are applied in the next reconcile loop, though again on a one-per-reconcile event basis. This is not a bug per se, as it will eventually result in creating all resources; however, it is suboptimal. This change ensures all resources defined in a single YAML manifest, separated using `---`, are processed in a single go.
zdtsw
approved these changes
Aug 8, 2024
ykaliuta
approved these changes
Aug 8, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ykaliuta, zdtsw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@zdtsw prow is borked? |
seems so, lets get it a rest and try again later today |
|
/retest |
959643d
into
opendatahub-io:incubation
8 checks passed
|
@zdtsw a review was needed from me? |
|
More on the reference side @israel-hdez since it is related to kserve |
zdtsw
referenced
this pull request
in zdtsw-forking/rhods-operator
Aug 15, 2024
…ed-hat-data-services#1159) Manifests used by Feature to create cluster resources can be either defined as a single resource per file or grouped together and separated using the `---` delimiter. Even though the former approach is currently preferred across the codebase, the latter is used to create Envoy filters for the KServe setup. When applying resources not yet present in the cluster, the original implementation returns after creating the first resource, leaving the rest unprocessed. They are applied in the next reconcile loop, though again on a one-per-reconcile event basis. This is not a bug per se, as it will eventually result in creating all resources; however, it is suboptimal. This change ensures all resources defined in a single YAML manifest, separated using `---`, are processed in a single go. (cherry picked from commit 959643d)
openshift-merge-bot bot
referenced
this pull request
in red-hat-data-services/rhods-operator
Aug 16, 2024
…1159) Manifests used by Feature to create cluster resources can be either defined as a single resource per file or grouped together and separated using the `---` delimiter. Even though the former approach is currently preferred across the codebase, the latter is used to create Envoy filters for the KServe setup. When applying resources not yet present in the cluster, the original implementation returns after creating the first resource, leaving the rest unprocessed. They are applied in the next reconcile loop, though again on a one-per-reconcile event basis. This is not a bug per se, as it will eventually result in creating all resources; however, it is suboptimal. This change ensures all resources defined in a single YAML manifest, separated using `---`, are processed in a single go. (cherry picked from commit 959643d)
MarianMacik
pushed a commit
to MarianMacik/opendatahub-operator
that referenced
this pull request
Jan 22, 2025
…flux/component-updates/odh-trustyai-service-operator-v2-17 chore(deps): update odh-trustyai-service-operator-v2-17 to 0ec163c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Manifests used by Feature to create cluster resources can be either defined as a single resource per file or grouped together and separated using the
---delimiter. Even though the former approach is currently preferred across the codebase, the latter is used to create Envoy filters for the KServe setup.When applying resources not yet present in the cluster, the original implementation returns after creating the first resource, leaving the rest unprocessed. They are applied in the next reconcile loop, though again on a one-per-reconcile event basis. This is not a bug per se, as it will eventually result in creating all resources; however, it is suboptimal.
This change ensures all resources defined in a single YAML manifest, separated using
---, are processed in a single go.How Has This Been Tested?
Enhanced integration test, which, when executed without this patch, fails due to described issue.
Screenshot or short clip
Merge criteria