Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: correct godoc #1152

Merged

Conversation

zdtsw
Copy link
Member

@zdtsw zdtsw commented Aug 5, 2024

Description

to follow up discussion #1145 (comment)
By reading upgrade document, my understanding is, the code logic is correct but the comments did not get updated.

How Has This Been Tested?

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@zdtsw zdtsw requested review from ykaliuta and VaishnaviHire and removed request for mattmahoneyrh and ajaypratap003 August 5, 2024 07:26
@ykaliuta
Copy link
Contributor

ykaliuta commented Aug 5, 2024

It will make conflict in #1145 I added removing of the line there

@zdtsw zdtsw force-pushed the chore_90 branch 2 times, most recently from 3761037 to e918b9c Compare August 5, 2024 09:08
@zdtsw
Copy link
Member Author

zdtsw commented Aug 5, 2024

It will make conflict in #1145 I added removing of the line there

i can make this as a draft , just need @VaishnaviHire to double confirm it is the right logic, then i can close this PR or you can cherry pick it to 1145 if you want.

@zdtsw zdtsw marked this pull request as draft August 5, 2024 09:33
@ykaliuta
Copy link
Contributor

ykaliuta commented Aug 5, 2024

It will make conflict in #1145 I added removing of the line there

i can make this as a draft , just need @VaishnaviHire to double confirm it is the right logic, then i can close this PR or you can cherry pick it to 1145 if you want.

Let me remove it from #1145 then. It is been outdated for a while already and is not related directly to the PR

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
@zdtsw zdtsw marked this pull request as ready for review August 8, 2024 15:51
@openshift-ci openshift-ci bot requested a review from grdryn August 8, 2024 15:51
Copy link
Member

@VaishnaviHire VaishnaviHire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Aug 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: VaishnaviHire

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Aug 9, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 8fc13ea into opendatahub-io:incubation Aug 9, 2024
11 checks passed
zdtsw referenced this pull request in zdtsw-forking/rhods-operator Aug 15, 2024
Signed-off-by: Wen Zhou <wenzhou@redhat.com>
(cherry picked from commit 8fc13ea)
openshift-merge-bot bot referenced this pull request in red-hat-data-services/rhods-operator Aug 16, 2024
Signed-off-by: Wen Zhou <wenzhou@redhat.com>
(cherry picked from commit 8fc13ea)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants