-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: correct godoc #1152
doc: correct godoc #1152
Conversation
It will make conflict in #1145 I added removing of the line there |
3761037
to
e918b9c
Compare
i can make this as a draft , just need @VaishnaviHire to double confirm it is the right logic, then i can close this PR or you can cherry pick it to 1145 if you want. |
Let me remove it from #1145 then. It is been outdated for a while already and is not related directly to the PR |
Signed-off-by: Wen Zhou <wenzhou@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: VaishnaviHire The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
8fc13ea
into
opendatahub-io:incubation
Signed-off-by: Wen Zhou <wenzhou@redhat.com> (cherry picked from commit 8fc13ea)
Signed-off-by: Wen Zhou <wenzhou@redhat.com> (cherry picked from commit 8fc13ea)
Description
to follow up discussion #1145 (comment)
By reading upgrade document, my understanding is, the code logic is correct but the comments did not get updated.
How Has This Been Tested?
Screenshot or short clip
Merge criteria