chore: cleanup Warning for unused packages #1151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wen Zhou <wenzhou@redhat.com>
|
it's |
ykaliuta
approved these changes
Aug 4, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ykaliuta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
112c262
into
opendatahub-io:incubation
8 checks passed
Yes exactly. V1.7 should not be there any more since we removed upgrade from old kfdef |
zdtsw
referenced
this pull request
in zdtsw-forking/rhods-operator
Aug 15, 2024
Signed-off-by: Wen Zhou <wenzhou@redhat.com> (cherry picked from commit 112c262)
openshift-merge-bot bot
referenced
this pull request
in red-hat-data-services/rhods-operator
Aug 16, 2024
Signed-off-by: Wen Zhou <wenzhou@redhat.com> (cherry picked from commit 112c262)
MarianMacik
pushed a commit
to MarianMacik/opendatahub-operator
that referenced
this pull request
Jan 22, 2025
…flux/component-updates/odh-model-controller-v2-17 chore(deps): update odh-model-controller-v2-17 to 8fde52c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
some packages are not used after we cleanedup old code
this is only to get these removed from go.mod
How Has This Been Tested?
Screenshot or short clip
Merge criteria