Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: for Managed cluster, we need another namespace or it will be deteced as self-managed #1146

Merged

Conversation

zdtsw
Copy link
Member

@zdtsw zdtsw commented Jul 30, 2024

During testing, we found out the Managed has Catsrc installed into a different cluster.

Description

https://issues.redhat.com/browse/RHOAIENG-10678

How Has This Been Tested?

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

deteced as self-managed

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
@openshift-ci openshift-ci bot requested review from ajaypratap003 and CFSNM July 30, 2024 16:02
@zdtsw zdtsw requested review from ykaliuta and lburgazzoli and removed request for ajaypratap003 and CFSNM July 30, 2024 16:02
@zdtsw
Copy link
Member Author

zdtsw commented Jul 30, 2024

@bdattoma FYI

Copy link

openshift-ci bot commented Jul 30, 2024

@bdattoma: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

openshift-ci bot commented Jul 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asanzgom, bdattoma, ykaliuta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zdtsw
Copy link
Member Author

zdtsw commented Jul 30, 2024

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit ae9133c into opendatahub-io:incubation Jul 30, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants