chore: renames IngressGatewaySpec type to GatewaySpec #1144
Conversation
| @@ -246,7 +246,7 @@ spec: | |||
| certificate: | |||
| description: Certificate specifies configuration of | |||
| the TLS certificate securing communications of the | |||
| for Ingress Gateway. | |||
| for gateway. | |||
There was a problem hiding this comment.
should not be a change in bundle/manifests ?
There was a problem hiding this comment.
The godoc changed because the type itself is not really about "ingress". It is Istio Gateway resource which can applied on ingress or egress service. Let me review it more thoroughly though. Thanks!
There was a problem hiding this comment.
It seems that Check config and readme updates / Ensure generated files are included (pull_request) job is not commenting on the PR (anymore?)
/cc @AjayJagan
3d3e6c9 to
7cfbae0
Compare
Original name is confusing as it does not actually define anything related to the ingress. It is configuring Istio Gateway resource which is, in case of Model Serving, attached to ingress service. This change makes the change of the golang type, but not publicly exposed `ingressGateway` config defined for KServe component.
7cfbae0 to
f943ac5
Compare
|
Putting on hold to prevent auto-merge. I would like @israel-hdez to weigh in |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: israel-hdez, zdtsw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
e80dcbe
into
opendatahub-io:incubation
…ervices#1144) Original name is confusing as it does not actually define anything related to the ingress. It is configuring Istio Gateway resource which is, in case of Model Serving, attached to ingress service. This change makes the change of the golang type, but not publicly exposed `ingressGateway` config defined for KServe component.
…ervices#1144) Original name is confusing as it does not actually define anything related to the ingress. It is configuring Istio Gateway resource which is, in case of Model Serving, attached to ingress service. This change makes the change of the golang type, but not publicly exposed `ingressGateway` config defined for KServe component. (cherry picked from commit e80dcbe)
Original name is confusing as it does not actually define anything related to the ingress. It is configuring Istio Gateway resource which is, in case of Model Serving, attached to ingress service. This change makes the change of the golang type, but not publicly exposed `ingressGateway` config defined for KServe component. (cherry picked from commit e80dcbe)
Description
The original name is confusing as it does not define anything related to the ingress. It configures Istio Gateway resource which is attached to ingress service in case of Model Serving.
Important
This change makes the change of the Golang type only. It does not change publicly exposed
ingressGatewayconfig defined for KServe component underDataScienceCluster.How Has This Been Tested?
Screenshot or short clip
Merge criteria