Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: devFlags for dashboard did not set correct values #1136

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

zdtsw
Copy link
Member

@zdtsw zdtsw commented Jul 24, 2024

Description

  • priority for image:
    1. when set devFlag:
      devFlag > imageParam
    2. when not set devFlag:
      imageParam > default value during operator build time
  • prioirty for url, title, groups:
    regardless set devFlags or not, always determinated by Platform value

https://issues.redhat.com/browse/RHOAIENG-10276

How Has This Been Tested?

local build: quay.io/wenzhou/opendatahub-operator-catalog:v2.15.10276

when DSC set to:

    dashboard:
      managementState: Managed

params.env is

admin_groups=odh-admins
odh-dashboard-image=<cpaas image>
dashboard-url=https://odh-dashboard-opendatahub.apps.rosa.wen-rosa-6.kuuz.p3.openshiftapps.com
section-title=OpenShift Open Data Hub

When DSC set to:

    dashboard:
      managementState: Managed
      devFlags:
        manifests:
          - contextDir: manifests
            uri: 'https://github.com/opendatahub-io/odh-dashboard/tarball/main'
    modelmeshserving: {}

params.env is

odh-dashboard-image=quay.io/opendatahub/odh-dashboard:main
dashboard-url=https://odh-dashboard-opendatahub.apps.rosa.wen-rosa-6.kuuz.p3.openshiftapps.com
section-title=OpenShift Open Data Hub
admin_groups=odh-admins

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

- priority for image:
	when set devFlag: devFlag > imageParam
	when ot set devFlag: imageParam > default value during opreator
build time
- prioirty for url, title, groups:
	regardless set devFlags or not, always determinated by Platform
value

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
@zdtsw zdtsw requested review from andrewballantyne, lucferbux and VaishnaviHire and removed request for ajaypratap003 and AjayJagan July 24, 2024 08:14
Copy link

openshift-ci bot commented Jul 24, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: andrewballantyne
Once this PR has been reviewed and has the lgtm label, please ask for approval from zdtsw. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zdtsw zdtsw added the odh-2.16 label Jul 29, 2024
@zdtsw zdtsw merged commit 00af708 into opendatahub-io:incubation Jul 30, 2024
7 of 8 checks passed
zdtsw referenced this pull request in zdtsw-forking/rhods-operator Jul 30, 2024
…services#1136)

- priority for image:
	when set devFlag: devFlag > imageParam
	when ot set devFlag: imageParam > default value during operator build time
- prioirty for url, title, groups:
	regardless set devFlags or not, always determinate by Platform value

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
zdtsw referenced this pull request in zdtsw-forking/rhods-operator Aug 1, 2024
…services#1136)

- priority for image:
	when set devFlag: devFlag > imageParam
	when ot set devFlag: imageParam > default value during operator build time
- prioirty for url, title, groups:
	regardless set devFlags or not, always determinate by Platform value

- upstream commit: 00af708

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
zdtsw referenced this pull request in red-hat-data-services/rhods-operator Aug 2, 2024
- priority for image:
	when set devFlag: devFlag > imageParam
	when ot set devFlag: imageParam > default value during operator build time
- prioirty for url, title, groups:
	regardless set devFlags or not, always determinate by Platform value

- upstream commit: 00af708

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants