Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fixes typos #1111

Merged
merged 1 commit into from
Jul 11, 2024
Merged

chore: fixes typos #1111

merged 1 commit into from
Jul 11, 2024

Conversation

bartoszmajsak
Copy link
Contributor

Description

Just a little nits found during working on something else.

How Has This Been Tested?

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@bartoszmajsak
chore: fixes typos
d0a18d5 
Just a little nits found during working on something else.
@bartoszmajsak bartoszmajsak requested a review from zdtsw July 11, 2024 08:55
@openshift-ci openshift-ci bot requested review from AjayJagan and etirelli July 11, 2024 08:55
zdtsw
zdtsw approved these changes Jul 11, 2024
View reviewed changes
Copy link
Member

@zdtsw zdtsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

must be me ....

@openshift-ci openshift-ci bot added the lgtm label Jul 11, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jul 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zdtsw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit eee87c0 into opendatahub-io:incubation Jul 11, 2024
8 checks passed
VaishnaviHire pushed a commit to VaishnaviHire/opendatahub-operator that referenced this pull request Jul 24, 2024
@bartoszmajsak @VaishnaviHire
chore: fixes typos (opendatahub-io#1111)
86ac280 
Just a little nits found during working on something else.

(cherry picked from commit eee87c0)
VaishnaviHire pushed a commit to VaishnaviHire/opendatahub-operator that referenced this pull request Jul 24, 2024
@bartoszmajsak @VaishnaviHire
chore: fixes typos (opendatahub-io#1111)
5dac19b 
Just a little nits found during working on something else.

(cherry picked from commit eee87c0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zdtsw zdtsw zdtsw approved these changes

@AjayJagan AjayJagan Awaiting requested review from AjayJagan

@etirelli etirelli Awaiting requested review from etirelli

Assignees

@zdtsw zdtsw

Labels
approved lgtm
Projects
ODH Platform Planning
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bartoszmajsak @zdtsw