Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Boolean fields are not allowed in OpenShift CRDs #476

Closed
etirelli opened this issue Aug 24, 2023 · 0 comments · Fixed by #481 or #491
Closed

Boolean fields are not allowed in OpenShift CRDs #476

etirelli opened this issue Aug 24, 2023 · 0 comments · Fixed by #481 or #491
Assignees
@etirelli
Labels
bug Something isn't working
Milestone
Feature: Rearchit...

Comments

@etirelli
Copy link
Contributor

Describe the bug
OpenShift conventions prohibit the use of boolean fields on CRDs:

https://github.com/openshift/enhancements/blob/master/dev-guide/api-conventions.md#do-not-use-boolean-fields

DataScienceCluster CR makes use of boolean fields to enable/disable component.

https://github.com/opendatahub-io/opendatahub-operator/blob/main/components/component.go#L11

This ticket is a blocker. The following changes should be implemented:

  1. replace the "enabled" field with a "managementState" field of type "ManagementState" following the OpenShift Operators API practices:

https://github.com/openshift/api/blob/release-4.8/operator/v1/types.go#L28

  1. update the DataScienceCluster API from v1alpha1 to v1

  2. replace the monitoring.enabled field in DSCInitialization by an enum field with similar semantics
@etirelli etirelli added the bug Something isn't working label Aug 24, 2023
@etirelli etirelli self-assigned this Aug 24, 2023
@etirelli etirelli moved this from Todo to In Progress in ODH Platform Planning Aug 24, 2023
@etirelli etirelli added this to the Feature: Rearchitecture milestone Aug 24, 2023
etirelli added a commit to etirelli/opendatahub-operator that referenced this issue Aug 24, 2023
@etirelli
Refactoring DataScienceCluster API as required by opendatahub-io#476
f01659d
@etirelli etirelli mentioned this issue Aug 24, 2023
Merged
3 tasks
etirelli added a commit to etirelli/opendatahub-operator that referenced this issue Aug 24, 2023
@etirelli
Refactoring DataScienceCluster API as required by opendatahub-io#476
56327c2
etirelli added a commit to etirelli/opendatahub-operator that referenced this issue Aug 24, 2023
@etirelli
Refactoring DataScienceCluster API as required by opendatahub-io#476
bb04f45
etirelli added a commit to etirelli/opendatahub-operator that referenced this issue Aug 25, 2023
@etirelli
Refactoring DataScienceCluster API as required by opendatahub-io#476
d542c77
etirelli added a commit to etirelli/opendatahub-operator that referenced this issue Aug 25, 2023
@etirelli
Refactoring DataScienceCluster API as required by opendatahub-io#476
9c9fa3b
etirelli added a commit to etirelli/opendatahub-operator that referenced this issue Aug 25, 2023
@etirelli
Refactoring DataScienceCluster API as required by opendatahub-io#476
8b5d419
etirelli added a commit to etirelli/opendatahub-operator that referenced this issue Aug 25, 2023
@etirelli
Refactoring DataScienceCluster API as required by opendatahub-io#476
559c5c1
@VaishnaviHire VaishnaviHire mentioned this issue Aug 25, 2023
Merged
3 tasks
etirelli added a commit to etirelli/opendatahub-operator that referenced this issue Aug 25, 2023
@etirelli
Refactoring DataScienceCluster API as required by opendatahub-io#476
5cfe22b
VaishnaviHire added a commit that referenced this issue Aug 28, 2023
@VaishnaviHire
Merge pull request #477 from etirelli/apiv1
530bd74 
Refactoring DataScienceCluster API as required by #476
@github-project-automation github-project-automation bot moved this from In Progress to Done in ODH Platform Planning Aug 28, 2023
VaishnaviHire pushed a commit to VaishnaviHire/opendatahub-operator that referenced this issue Aug 28, 2023
@etirelli @VaishnaviHire
Refactoring DataScienceCluster API as required by opendatahub-io#476
d60ac38 
(cherry picked from commit 5cfe22b)

Update e2e test:

- more timeout due to new components (for in sequence run)
- change validat component to run in concurrent
- add Ray in the testing
- logs for error message
- rename functions to align names
- set skip-deletion=false to test this case

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
(cherry picked from commit d6ffe75)

Improving godoc for the managementState field

(cherry picked from commit a2cd907)

fix(rbac): adds list role for configmaps and namespaces

otherwise operator constantly emit errors about those cluster roles missing

(cherry picked from commit 7d1cfb2)

fix: cleaned up mistyped rbac verbs

(cherry picked from commit a25fb98)

Refactor DSCInitialization API  (opendatahub-io#481)

* fix(rbac): adds list role for configmaps and namespaces

otherwise operator constantly emit errors about those cluster roles missing

* Update DSCInitialization api to v1

* Replace boolean field with managementState

* Add devFlags to DSCInitialization

---------

Co-authored-by: bartoszmajsak <bartosz.majsak@gmail.com>
(cherry picked from commit 1e08b1f)

Update RHODS bundle

Update rhods namespaces
@VaishnaviHire VaishnaviHire mentioned this issue Aug 28, 2023
Merged
VaishnaviHire referenced this issue in red-hat-data-services/rhods-operator Aug 28, 2023
@VaishnaviHire
Merge pull request #46 from VaishnaviHire/update_api
df363a1 
Refactoring DataScienceCluster API as required by #476
This was referenced Aug 29, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@etirelli etirelli

Labels
bug Something isn't working
Projects
ODH Platform Planning
Status: Done
Milestone
Feature: Rearchitecture
1 participant
@etirelli