Integrate Serving fields to the DataScienceCluster api #232
Labels
Milestone
Comments
1 task
|
duplicated as #666? |
|
Closing this since its a duplicate #666 |
VaishnaviHire
pushed a commit
to VaishnaviHire/opendatahub-operator
that referenced
this issue
Apr 9, 2024
…ahub-io#232) * chore: move testing fixtures to fixtures directory (opendatahub-io#906) This change aims to enhance the readability of our test suite. It brings `/crds` and `/templates` into `/fixtures` and moves more helper functions out into dedicated files. * feat(build): adds gci to go fmt target (opendatahub-io#925) This update incorporates the `gci` tool into the `make fmt` command, aiming to improve the formatting of Go files and ensure that imports adhere to our established conventions. Unfortunately, due to how `.golangci.yml` is defined, we are not able to just use `--disable-all --enable=gci` flags. This yields an error as we use `enable-all` and `disable` in the config file for linter. To address this, the `golangci-lint` configuration is dynamically adjusted using the `yq` tool, which is now included in our toolchain. This process creates a temporary configuration file specifically for `golangci-lint` execution, ensuring `gci`'s integration without altering the primary linting setup. Furthermore, the generated temporary file is added to the `CLEANFILES` list, ensuring its removal when calling `make clean`, maintaining a clean build environment. To prevent this temporary file from being tracked by Git, a `*.mktmp.*` pattern has been added to our `.gitignore`, safeguarding against accidental inclusion of temporary files in the repository.: ### Tidies - removes duplicate `blank` import section in `gci` config, otherwise it can add `_` imports twice * chore: splits feature tests to separate files (opendatahub-io#924) As the number of test cases (grouped as `Describe`) started to grow, we can split a single file into several groups per functionality. Follow-up for opendatahub-io#906. * fix(dashboard): do not set owner on CR (opendatahub-io#923) Signed-off-by: Wen Zhou <wenzhou@redhat.com> * (fix): Description patch during make bundle (opendatahub-io#926) * feat(DW): prepare CF,ray,kueue for GA (opendatahub-io#929) Signed-off-by: Wen Zhou <wenzhou@redhat.com> * fix(dashboard): wrong path for consolelink in downstream (opendatahub-io#933) Signed-off-by: Wen Zhou <wenzhou@redhat.com> * docs: remove modelregistry and update default application NS Signed-off-by: Zhou, Wen <wenzhou@redhat.com> --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Zhou, Wen <wenzhou@redhat.com> Co-authored-by: Cameron Garrison <cgarriso@redhat.com> Co-authored-by: Bartosz Majsak <bartosz.majsak@gmail.com> Co-authored-by: Ajay Jaganathan <36824134+AjayJagan@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
No description provided.
The text was updated successfully, but these errors were encountered: