fix: add default managementState as Removed to allow new components t…

…o show up in old DSCs, fixes RHOAIENG-14194 Signed-off-by: Dhiraj Bokde <dhirajsb@users.noreply.github.com>
opendatahub-io · Oct 9, 2024 · 99c1e85 · 99c1e85
1 parent db0fa50
commit 99c1e85
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 1 deletion.
diff --git a/components/component.go b/components/component.go
@@ -29,6 +29,7 @@ type Component struct {
 	//               or if it is installed, the operator will try to remove it
 	//
 	// +kubebuilder:validation:Enum=Managed;Removed
+	// +kubebuilder:default=Removed
 	ManagementState operatorv1.ManagementState `json:"managementState,omitempty"`
 	// Add any other common fields across components below
 

diff --git a/config/crd/bases/datasciencecluster.opendatahub.io_datascienceclusters.yaml b/config/crd/bases/datasciencecluster.opendatahub.io_datascienceclusters.yaml
@@ -79,6 +79,7 @@ spec:
                             type: array
                         type: object
                       managementState:
+                        default: Removed
                         description: |-
                           Set to one of the following values:
 
@@ -125,6 +126,7 @@ spec:
                             type: array
                         type: object
                       managementState:
+                        default: Removed
                         description: |-
                           Set to one of the following values:
 
@@ -173,6 +175,7 @@ spec:
                             type: array
                         type: object
                       managementState:
+                        default: Removed
                         description: |-
                           Set to one of the following values:
 
@@ -232,6 +235,7 @@ spec:
                             type: array
                         type: object
                       managementState:
+                        default: Removed
                         description: |-
                           Set to one of the following values:
 
@@ -336,6 +340,7 @@ spec:
                             type: array
                         type: object
                       managementState:
+                        default: Removed
                         description: |-
                           Set to one of the following values:
 
@@ -384,6 +389,7 @@ spec:
                             type: array
                         type: object
                       managementState:
+                        default: Removed
                         description: |-
                           Set to one of the following values:
 
@@ -430,6 +436,7 @@ spec:
                             type: array
                         type: object
                       managementState:
+                        default: Removed
                         description: |-
                           Set to one of the following values:
 
@@ -490,6 +497,7 @@ spec:
                             type: array
                         type: object
                       managementState:
+                        default: Removed
                         description: |-
                           Set to one of the following values:
 
@@ -536,6 +544,7 @@ spec:
                             type: array
                         type: object
                       managementState:
+                        default: Removed
                         description: |-
                           Set to one of the following values:
 
@@ -582,6 +591,7 @@ spec:
                             type: array
                         type: object
                       managementState:
+                        default: Removed
                         description: |-
                           Set to one of the following values:
 
@@ -628,6 +638,7 @@ spec:
                             type: array
                         type: object
                       managementState:
+                        default: Removed
                         description: |-
                           Set to one of the following values:
 

diff --git a/docs/api-overview.md b/docs/api-overview.md
@@ -57,7 +57,7 @@ _Appears in:_
 
 | Field | Description | Default | Validation |
 | --- | --- | --- | --- |
-| `managementState` _[ManagementState](#managementstate)_ | Set to one of the following values:<br /><br />- "Managed" : the operator is actively managing the component and trying to keep it active.<br />              It will only upgrade the component if it is safe to do so<br /><br />- "Removed" : the operator is actively managing the component and will not install it,<br />              or if it is installed, the operator will try to remove it |  | Enum: [Managed Removed] <br /> |
+| `managementState` _[ManagementState](#managementstate)_ | Set to one of the following values:<br /><br />- "Managed" : the operator is actively managing the component and trying to keep it active.<br />              It will only upgrade the component if it is safe to do so<br /><br />- "Removed" : the operator is actively managing the component and will not install it,<br />              or if it is installed, the operator will try to remove it | Removed | Enum: [Managed Removed] <br /> |
 | `devFlags` _[DevFlags](#devflags)_ | Add developer fields |  |  |