Skip to content

Commit

Permalink
fix(make): removes duplicated e2e flag declaration (#595)
Browse files Browse the repository at this point in the history
  • Loading branch information
bartoszmajsak authored Oct 4, 2023
1 parent c705d7e commit 2522ad3
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ SHELL = /usr/bin/env bash -o pipefail
.SHELLFLAGS = -ec

# E2E tests additional flags
E2E_TEST_FLAGS = "--skip-deletion=true" # See README.md
E2E_TEST_FLAGS = "--skip-deletion=false" -timeout 15m # See README.md, default go test timeout 10m

# Default image-build is to not use local odh-manifests folder
# set to "true" to use local instead
Expand Down Expand Up @@ -150,8 +150,6 @@ lint: golangci-lint ## Run golangci-lint against code.
test: manifests generate fmt vet envtest ## Run tests.
KUBEBUILDER_ASSETS="$(shell $(ENVTEST) use $(ENVTEST_K8S_VERSION) --bin-dir $(LOCALBIN) -p path)" go test ./controllers/... -v -coverprofile cover.out

# E2E tests additional flags
E2E_TEST_FLAGS = "--skip-deletion=false" -timeout 15m # See README.md, default go test timeout 10m

.PHONY: get-manifests
get-manifests: ## Fetch components manifests from remote git repo
Expand Down

0 comments on commit 2522ad3

Please sign in to comment.