-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add sanity check on regex match results while determining runtime image #245
add sanity check on regex match results while determining runtime image #245
Conversation
Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the moment, it is ok for current situation so I will approve this but the regexp should be improved to cover all possible image URL formats like the following:
"docker.io/library/ubuntu:latest",
"myregistry.com/mynamespace/myimage@sha256:abcdef123456",
"myregistry.com/myimage:latest",
"myimage@sha256:abcdef123456",
"myimage:latest",
and need to add unit tests for this.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jooho, VedantMahabaleshwarkar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…kar/eng-10286 add sanity check on regex match results while determining runtime image
…kar/eng-10286 add sanity check on regex match results while determining runtime image
…kar/eng-10286 add sanity check on regex match results while determining runtime image
…kar/eng-10286 add sanity check on regex match results while determining runtime image
Description
Fixes : https://issues.redhat.com/browse/RHOAIENG-10286
How Has This Been Tested?
Merge criteria: