Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kserve Dashboard Reconciler #220

Merged

Conversation

ashley-o0o
Copy link
Contributor

@ashley-o0o ashley-o0o commented Jun 11, 2024

Description

Add logic for configmap creation for Kserve metrics in ODH Model Controller
Closes: RHOAIENG-3956

How Has This Been Tested?

  • install odh
  • install the following DSC
  • components:
      codeflare:
        managementState: Removed
      kserve:
        devFlags:
          manifests:
            - contextDir: config
              sourcePath: overlays/odh
              uri: 'https://github.com/opendatahub-io/kserve/tarball/master'
            - contextDir: config
              sourcePath: ''
              uri: 'https://github.com/ashley-o0o/odh-model-controller/tarball/kserveReconciler'
        managementState: Managed
        serving:
          ingressGateway:
            certificate:
              type: SelfSigned
          managementState: Managed
          name: knative-serving
      modelregistry:
        managementState: Removed
      trustyai:
        managementState: Removed
      ray:
        managementState: Removed
      kueue:
        managementState: Removed
      workbenches:
        managementState: Removed
      dashboard:
        managementState: Managed
      modelmeshserving:
        managementState: Removed
      datasciencepipelines:
        managementState: Removed
      trainingoperator:
        managementState: Removed
    
  • create a data science project
  • deploy a sample model for each supported ServingRuntime
  • ensure -metrics-dashboard configmap exists, and contents are correct
  • ensure configmap is deleted when model is deleted.
  • ensure that the configmap cannot be changed by the user (the reconciler should revert changes)

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link
Contributor

openshift-ci bot commented Jun 11, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ashley-o0o ashley-o0o marked this pull request as ready for review June 12, 2024 19:27
@spolti
Copy link
Member

spolti commented Jun 12, 2024

CI is failing due error: build error: building at STEP "COPY controllers/constants/ovms-metrics.json metrics_dashboards/ovms-metrics.json": checking on sources under "/tmp/build/inputs": copier: stat: "/controllers/constants/ovms-metrics.json": no such file or directory

config/base/params.env Outdated Show resolved Hide resolved
@ashley-o0o ashley-o0o force-pushed the kserveReconciler branch 3 times, most recently from 41c3d4d to 3e8d279 Compare June 13, 2024 14:22
@ashley-o0o ashley-o0o mentioned this pull request Jun 14, 2024
3 tasks
Containerfile Show resolved Hide resolved
@ashley-o0o ashley-o0o force-pushed the kserveReconciler branch 6 times, most recently from 0addbfa to 980f6b3 Compare June 18, 2024 18:29
@ashley-o0o ashley-o0o force-pushed the kserveReconciler branch 3 times, most recently from 5abfc3e to 235ffa3 Compare June 21, 2024 19:22
Signed-off-by: Ashley McEntee <amcent@redhat.com>

Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com>
Copy link
Contributor

@VedantMahabaleshwarkar VedantMahabaleshwarkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Jun 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashley-o0o, VedantMahabaleshwarkar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [VedantMahabaleshwarkar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 8eb9a75 into opendatahub-io:main Jun 21, 2024
5 checks passed
VedantMahabaleshwarkar referenced this pull request in VedantMahabaleshwarkar/odh-model-controller Jul 17, 2024
…kserveReconciler"

This reverts commit 8eb9a75, reversing
changes made to 14d7b8f.
VedantMahabaleshwarkar referenced this pull request in VedantMahabaleshwarkar/odh-model-controller Jul 17, 2024
…kserveReconciler"

This reverts commit 8eb9a75, reversing
changes made to 14d7b8f.

Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com>
VedantMahabaleshwarkar referenced this pull request in VedantMahabaleshwarkar/odh-model-controller Jul 17, 2024
…kserveReconciler"

This reverts commit 8eb9a75, reversing
changes made to 14d7b8f.

Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com>
@VedantMahabaleshwarkar VedantMahabaleshwarkar mentioned this pull request Jul 17, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants