Fix to more accurately communicate build statuses #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdcabrera
approved these changes
Sep 9, 2021
kywalker-rh
approved these changes
Sep 9, 2021
There was a problem hiding this comment.
@jeff-phillips-18: lgtm, thanks for all the explanation and back-and-forth to get to this solution.
jeff-phillips-18
added a commit
to jeff-phillips-18/odh-dashboard
that referenced
this pull request
Sep 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
Jira: https://issues.redhat.com/browse/RHODS-1649
Analysis / Root cause:
Builds that are not started were flagged as in progress
Solution Description:
Track builds that have not yet been started and communicate un-started builds to the user.
Update to not use the base build configs for status.
Upon completion of builds, notify the user of all the failures that occurred.
Screen shots / Gifs for design review:
