Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch real user name, display username in the header. #73

Merged

Conversation

jeff-phillips-18
Copy link
Contributor

Fixes:
Jira: https://issues.redhat.com/browse/RHODS-851

Analysis / Root cause:
The dashboard shows a user icon whereas other applications show the user name.

Solution Description:
Determine the correct username and display it in the header rather than the user icon.

/cc @DaoDaoNoCode

Copy link
Member

@DaoDaoNoCode DaoDaoNoCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, thanks! @jeff-phillips-18

@jeff-phillips-18 jeff-phillips-18 merged commit 64af329 into opendatahub-io:master Jul 6, 2021
tumido pushed a commit to tumido/odh-dashboard that referenced this pull request Oct 20, 2021
@jeff-phillips-18 jeff-phillips-18 deleted the header-username branch November 12, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants