Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data Connections List #671

Merged
merged 1 commit into from
Oct 18, 2022
Merged

Data Connections List #671

merged 1 commit into from
Oct 18, 2022

Conversation

andrewballantyne
Copy link
Member

Resolves: #491

Description

Adds a data connection list that currently only lists a subset of secrets that are AWS secrets.

Eg:

apiVersion: v1
kind: Secret
metadata:
  annotations:
    opendatahub.io/related-notebooks: '["notebook-td8hf5"]' # A notebook I had
  labels:
    opendatahub.io/managed: 'true' # the key search factor for the fetch all
  name: example
  namespace: kube-3aadmin-3djwta # my namespace
type: Opaque
stringData: # nonsense data for example
  AWS_ACCESS_KEY_ID: something
  AWS_SECRET_ACCESS_KEY: password
  AWS_S3_ENDPOINT: https://s3.amazonaws.com/
  AWS_DEFAULT_REGION: us-east-1

How Has This Been Tested?

Create a Notebook (from the UI), create an AWS Secret (from OpenShift Console -- #670 will cover this on the UI later).

@andrewballantyne andrewballantyne linked an issue Oct 17, 2022 that may be closed by this pull request
[DSG]: Support Data Connections List #491
Closed
DaoDaoNoCode
DaoDaoNoCode approved these changes Oct 18, 2022
View reviewed changes
Copy link
Member

@DaoDaoNoCode DaoDaoNoCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a small comment, but overall it lgtm

frontend/src/api/network/secrets.ts
@@ -14,6 +15,13 @@ export const getSecret = (projectName: string, secretName: string): Promise<Secr
});
};

export const getSecretsByLabel = (label: string, namespace: string): Promise<SecretKind[]> => {
return k8sListResource<SecretKind>({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am always wondering whether we could use k8sListResourceItems here instead of processing it, like what I did when fetching ImageStreams

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, I understand, I thought of it. I think there is a problem with the items fetch -- I don't recall what it was, but I saw it crash under some circumstance that I don't recall. We'll need to do a lot of cleanup anyways, so I'll mark this down and investigate it when we get the other important stuff done.

@openshift-ci openshift-ci bot added the lgtm label Oct 18, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 18, 2022

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: DaoDaoNoCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 0b53a26 into opendatahub-io:f/dsg Oct 18, 2022
openshift-merge-robot pushed a commit that referenced this pull request Oct 31, 2022
@andrewballantyne @DaoDaoNoCode @dlabaj
[Feature] Data Science Grouping (#689)
e8ff744 
* Add empty DSG page & nav (#471)

* Add empty DSG page & nav

* Rework the way navs work & add feature flag

* Kubernetes Pass Through API & SDK Initialization (#279)

* SDK npm installed

* Pass-through api & SDK setup

* Migrated ConfigMap, Secret, PVC to SDK calls

* Adjust k8s pass through to handle bad create urls

* Code cleanup

* Add local dev token & header access token support

* Remove v12 from the supported node-versions

* Fix test issue & convert starting notebook to SDK call

* Added some docs and fixed a type issue

* Address a couple issues with the flow

* Improve server logging

* Misc cleanup of DSG (#481)

* Add project view details page (#578)

* Add project view details page

* address comment

* make jumplink items generic

* modify type

* small fixes

* Create projects (#597)

* Create projects

* Added workaround for self signed certs

* List Projects & Delete Project (#605)

* List of Projects with Notebook Details

* Make Notebooks have display annotations

* Pagination and filter

* Handle pagination edge cases

* Edit projects

* Improve edit modal data management

* Delete project

* Add an filterd empty row

* Cleaned up projects to be more organized & fixed issue with 404 project

* Add a watcher for when starting the notebook via toggle

* Add bad certif workaround to debug script

* Create add storage modal (#582)

* Create add storage modal

* refactor files

* clean up import

* fix layout of existing storage

* pass less props

* address comments

* Add part of spawner page (#610)

* Add part of spawner page

* add creating notebook

* fix small issues

* Add storage section for spawner page (#637)

* Workspace Table (#660)

* Follow up fix for #610 and #637 (#664)

* follow up fix for #610

* follow up PR #637

* clean up

* Code cleanup (#665)

* Cleanup of Spawner code

* Update the image details in the workspaces table

* Add storage list layout (#666)

* Add storage list layout

* address comments

* make JSX and functions inline

* Data Connections List (#671)

* Stop Notebook Confirmation Modal (#672)

* Delete Notebook Modal (#673)

* Delete Notebook Modal

* Refresh only if finished deleting

* Spawner Environment Section (#670)

* Added spawner page.

Refactor code part 1.

Refactor secret and config map.

Added upload code.

Fixed style issues.

* Refactored code.

* Disabled AWS.

* Updated pass through code.

* Fixed linting errors.

* Removed some dead code.

AWS update.

updates to secret


Reverted code.

* Fixed linting errors.

* Delete Storage Modal (#677)

* Prometheus connection for inUse storage value (#676)

* Added spawner page. (#679)

Refactor code part 1.

Refactor secret and config map.

Added upload code.

Fixed style issues.

Refactored code.

Disabled AWS.

Updated pass through code.

Fixed linting errors.

Removed some dead code.

AWS update.

updates to secret

Added AWS code.

Fixed rebase files.

Fixed linting errors.

* Cleanup Random DSG stuff (#678)

* Added breadcrumb for project details and spawner page. (#682)

* Adjust Storage based on UX input (#684)

* Add status tooltip and start notebook modal (#683)

* Add status tooltip and start notebook modal

* get projectName from notebook namespace

* Environment Spawner Section & Data Connections (#688)

* Cleanup lint issues

* Create dedicated OAuthclient (#658)

* DSG Fixes (#696)

* Source all the details data from the same spot

* Connected Workspaces now pull from context

* Follow-up fix for DSG work (#695)

* bug fixes for dsg

* rebase

* Refresh notebook status and fetch all status periodically (#697)

* refresh notebook status and fetch all status periodically

* small fix for listening notebook

* some rename and clean up

* add input group for mount path and change placeholder text

* refactor useRelatedNotebooks

* Improve storage section features and bug fix (#698)

* use config pvs size and some small bug fix

* storage part refactor

* add check for terminated status

* Add ability to delete attached PVC (#699)

* Add ability to delete attached PVC

* add inline for alert

* Improve Project Creation & Data Connection Modal (#700)

* Misc DSG Fixes

* Projects creation flexibility & data connection functionality

* Fixes for DSG (#701)

* update storage name and description

* add aria-label and id on spawner page and project details page

* add data-label for table cells

* add GPU field and remove secure route for backend GPU

* add generic delete modal

* Translate display names into k8s names (#702)

* Translate display names into k8s names

* Minor changes to text and support a more direct delete button text

* Fix lint issue

* Fixes and features for DSG (#704)

* delete data connection will also delete envFrom field

* change switch to separate text and switch button

* indent data connection list

* make data connection name sortable

* sort notebooks by status

* change select menuAppendTo on spawner page

* add truncate for dependency package details

* make table show expand style correctly

* clean up dependencies

* add label to all the resources created by dashboard

* UX Feedback -- DSG Changes (#705)

* Add icon & tooltip for k8s resource identification

* Allow searching on user associated to Projects

* Improved tooltips and added more to the project creation

* Add generic padding to the bottom of the scrollable content

* Cleanup delete modal as it closes

* Updated UX wording

* Edit Notebook

* Realign tooltip -- removeFindDomNode issue

* Fix lint issues

Co-authored-by: Juntao Wang <37624318+DaoDaoNoCode@users.noreply.github.com>
Co-authored-by: Donald Labaj <dlabaj@redhat.com>
Co-authored-by: Samu <svelosol@redhat.com>
strangiato pushed a commit to strangiato/odh-dashboard that referenced this pull request Oct 18, 2023
@andrewballantyne @DaoDaoNoCode
@dlabaj @strangiato
[Feature] Data Science Grouping (opendatahub-io#689)
30afb80 
* Add empty DSG page & nav (opendatahub-io#471)

* Add empty DSG page & nav

* Rework the way navs work & add feature flag

* Kubernetes Pass Through API & SDK Initialization (opendatahub-io#279)

* SDK npm installed

* Pass-through api & SDK setup

* Migrated ConfigMap, Secret, PVC to SDK calls

* Adjust k8s pass through to handle bad create urls

* Code cleanup

* Add local dev token & header access token support

* Remove v12 from the supported node-versions

* Fix test issue & convert starting notebook to SDK call

* Added some docs and fixed a type issue

* Address a couple issues with the flow

* Improve server logging

* Misc cleanup of DSG (opendatahub-io#481)

* Add project view details page (opendatahub-io#578)

* Add project view details page

* address comment

* make jumplink items generic

* modify type

* small fixes

* Create projects (opendatahub-io#597)

* Create projects

* Added workaround for self signed certs

* List Projects & Delete Project (opendatahub-io#605)

* List of Projects with Notebook Details

* Make Notebooks have display annotations

* Pagination and filter

* Handle pagination edge cases

* Edit projects

* Improve edit modal data management

* Delete project

* Add an filterd empty row

* Cleaned up projects to be more organized & fixed issue with 404 project

* Add a watcher for when starting the notebook via toggle

* Add bad certif workaround to debug script

* Create add storage modal (opendatahub-io#582)

* Create add storage modal

* refactor files

* clean up import

* fix layout of existing storage

* pass less props

* address comments

* Add part of spawner page (opendatahub-io#610)

* Add part of spawner page

* add creating notebook

* fix small issues

* Add storage section for spawner page (opendatahub-io#637)

* Workspace Table (opendatahub-io#660)

* Follow up fix for opendatahub-io#610 and opendatahub-io#637 (opendatahub-io#664)

* follow up fix for opendatahub-io#610

* follow up PR opendatahub-io#637

* clean up

* Code cleanup (opendatahub-io#665)

* Cleanup of Spawner code

* Update the image details in the workspaces table

* Add storage list layout (opendatahub-io#666)

* Add storage list layout

* address comments

* make JSX and functions inline

* Data Connections List (opendatahub-io#671)

* Stop Notebook Confirmation Modal (opendatahub-io#672)

* Delete Notebook Modal (opendatahub-io#673)

* Delete Notebook Modal

* Refresh only if finished deleting

* Spawner Environment Section (opendatahub-io#670)

* Added spawner page.

Refactor code part 1.

Refactor secret and config map.

Added upload code.

Fixed style issues.

* Refactored code.

* Disabled AWS.

* Updated pass through code.

* Fixed linting errors.

* Removed some dead code.

AWS update.

updates to secret


Reverted code.

* Fixed linting errors.

* Delete Storage Modal (opendatahub-io#677)

* Prometheus connection for inUse storage value (opendatahub-io#676)

* Added spawner page. (opendatahub-io#679)

Refactor code part 1.

Refactor secret and config map.

Added upload code.

Fixed style issues.

Refactored code.

Disabled AWS.

Updated pass through code.

Fixed linting errors.

Removed some dead code.

AWS update.

updates to secret

Added AWS code.

Fixed rebase files.

Fixed linting errors.

* Cleanup Random DSG stuff (opendatahub-io#678)

* Added breadcrumb for project details and spawner page. (opendatahub-io#682)

* Adjust Storage based on UX input (opendatahub-io#684)

* Add status tooltip and start notebook modal (opendatahub-io#683)

* Add status tooltip and start notebook modal

* get projectName from notebook namespace

* Environment Spawner Section & Data Connections (opendatahub-io#688)

* Cleanup lint issues

* Create dedicated OAuthclient (opendatahub-io#658)

* DSG Fixes (opendatahub-io#696)

* Source all the details data from the same spot

* Connected Workspaces now pull from context

* Follow-up fix for DSG work (opendatahub-io#695)

* bug fixes for dsg

* rebase

* Refresh notebook status and fetch all status periodically (opendatahub-io#697)

* refresh notebook status and fetch all status periodically

* small fix for listening notebook

* some rename and clean up

* add input group for mount path and change placeholder text

* refactor useRelatedNotebooks

* Improve storage section features and bug fix (opendatahub-io#698)

* use config pvs size and some small bug fix

* storage part refactor

* add check for terminated status

* Add ability to delete attached PVC (opendatahub-io#699)

* Add ability to delete attached PVC

* add inline for alert

* Improve Project Creation & Data Connection Modal (opendatahub-io#700)

* Misc DSG Fixes

* Projects creation flexibility & data connection functionality

* Fixes for DSG (opendatahub-io#701)

* update storage name and description

* add aria-label and id on spawner page and project details page

* add data-label for table cells

* add GPU field and remove secure route for backend GPU

* add generic delete modal

* Translate display names into k8s names (opendatahub-io#702)

* Translate display names into k8s names

* Minor changes to text and support a more direct delete button text

* Fix lint issue

* Fixes and features for DSG (opendatahub-io#704)

* delete data connection will also delete envFrom field

* change switch to separate text and switch button

* indent data connection list

* make data connection name sortable

* sort notebooks by status

* change select menuAppendTo on spawner page

* add truncate for dependency package details

* make table show expand style correctly

* clean up dependencies

* add label to all the resources created by dashboard

* UX Feedback -- DSG Changes (opendatahub-io#705)

* Add icon & tooltip for k8s resource identification

* Allow searching on user associated to Projects

* Improved tooltips and added more to the project creation

* Add generic padding to the bottom of the scrollable content

* Cleanup delete modal as it closes

* Updated UX wording

* Edit Notebook

* Realign tooltip -- removeFindDomNode issue

* Fix lint issues

Co-authored-by: Juntao Wang <37624318+DaoDaoNoCode@users.noreply.github.com>
Co-authored-by: Donald Labaj <dlabaj@redhat.com>
Co-authored-by: Samu <svelosol@redhat.com>
@andrewballantyne andrewballantyne deleted the data-connection-list branch June 26, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaoDaoNoCode DaoDaoNoCode DaoDaoNoCode approved these changes

@lucferbux lucferbux Awaiting requested review from lucferbux

Assignees

@DaoDaoNoCode DaoDaoNoCode

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DSG]: Support Data Connections List
3 participants
@andrewballantyne @DaoDaoNoCode @openshift-merge-robot