Use notebook name for build status messages #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdcabrera
approved these changes
Jun 17, 2021
jeff-phillips-18
pushed a commit
to jeff-phillips-18/odh-dashboard
that referenced
this pull request
Jun 21, 2021
This change fixes a typo in the description for the python-accelerated-numba-tutorial tutorial widget.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
Build failure messages show the name of the build config when builds fail, this name is not what a user would expect to see.
Analysis / Root cause:
There was no way to determine which notebook a build config was for.
Solution Description:
Now that labels for the notebook name have been added to the notebook build configs (red-hat-data-services/odh-deployer#114) use this notebook name for build status messages shown to the users when builds fail.