Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding prettier automatic code formatting #5

Merged
merged 2 commits into from
Jun 19, 2020
Merged

Adding prettier automatic code formatting #5

merged 2 commits into from
Jun 19, 2020

Conversation

cfchase
Copy link
Member

@cfchase cfchase commented Jun 19, 2020

I think it's important we stay on the same page as far as code formatting. It's widely used in RH and in React in general. There's more info in the create react app docs.

I just went with defaults except for the line width, but feel free to edit the .prettierrc file as needed.

Actual configuration (package.json and .prettierrc) in commit c674a22

Formatting changes are in commit 7c4f9f2

@cfchase cfchase requested review from PARTHSONI95 and crobby June 19, 2020 17:23
Copy link
Contributor

@PARTHSONI95 PARTHSONI95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds perfect!

@PARTHSONI95 PARTHSONI95 merged commit 38df5fe into master Jun 19, 2020
@cfchase cfchase deleted the prettier branch July 22, 2020 19:04
accorvin pushed a commit to accorvin/odh-dashboard that referenced this pull request Apr 24, 2021
cam-garrison added a commit to cam-garrison/odh-dashboard that referenced this pull request Jun 27, 2023
…io#5)

* update existing annotation reference

* use ns annotation in backend route fetching
cam-garrison added a commit to cam-garrison/odh-dashboard that referenced this pull request Jul 31, 2023
…io#5)

* update existing annotation reference

* use ns annotation in backend route fetching
lokeshrangineni pushed a commit to lokeshrangineni/odh-dashboard that referenced this pull request Oct 3, 2024
Added mockNimServingRuntimeTemplate mock function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants