Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add downstream changes #48

Conversation

VaishnaviHire
Copy link
Member

This PR is created to list down changes that can be moved to opendatahub-io org.

jeff-phillips-18 and others added 30 commits January 25, 2021 15:58
Update project structure, build, use Typescript for frontend
* Updates to allow 'coming soon' and show getting started side panel

* store selected app in the URL in explore
* Add rhodes-factory-floor tutorial

* Fix sort by doc type
Renamed 'how do i' to 'how to'
Updated category types
Removed mock apps (out of date)
Updated mast head logo
styling fixes for getting started markdown
@jeff-phillips-18
Copy link
Contributor

I'd like to add the changes to how we fetch the application definitions and documentation from red-hat-data-services#79

@crobby crobby requested a review from cfchase June 1, 2021 18:11
@crobby
Copy link
Contributor

crobby commented Jun 1, 2021

Are we good to go on this one yet? @jeff-phillips-18 @VaishnaviHire

@VaishnaviHire
Copy link
Member Author

#48 (comment)

Not sure if we first want to include changes from this PR - red-hat-data-services#88 ?

@jeff-phillips-18
Copy link
Contributor

I think maybe we are better of to go forward with this PR and add changes for red-hat-data-services#88 later. @crobby @cfchase thoughts?

@crobby
Copy link
Contributor

crobby commented Jun 1, 2021

I think maybe we are better of to go forward with this PR and add changes for red-hat-data-services#88 later. @crobby @cfchase thoughts?

I'm happy with that approach.

@cfchase
Copy link
Member

cfchase commented Jun 1, 2021

I think maybe we are better of to go forward with this PR and add changes for red-hat-data-services#88 later. @crobby @cfchase thoughts?

Sounds good to me.

@jeff-phillips-18 jeff-phillips-18 merged commit 9278a0e into opendatahub-io:master Jun 2, 2021
@lucferbux lucferbux deleted the downstream_changes branch March 31, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.