Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress e2e Test - Verifies users can create/delete a Data Connection #3686

Merged

Conversation

antowaddle
Copy link
Contributor

@antowaddle antowaddle commented Jan 27, 2025

https://issues.redhat.com/browse/RHOAIENG-17426

Description

  • Migrate 'Verifies users can delete a Data connection' to Cypress ODS-1826
  • This test creates a Data Connection via the UI and then deletes it

How Has This Been Tested?

  • An oc login should be performed in the cluster before running the test
  • test-variables.yml should be configured properly
  • Export the path to the test-variables.yml: $ export CY_TEST_CONFIG=<path_to>/test-variables.yml
  • Locally against a PSI cluster and ODH-Nightly - note that as a new tESTid IS being added here, after cloning this branch, the Dashboard should be launched locally and the test executed as the dashboard frontend (localhost etc.)
    image

Test Impact

  • None - this is a test

How to run?

Go to odh-dashboard/frontend/src/tests/cypress and run the command npx cypress open . This will open the Cypress UI where testDataConnectionCreation.cy.ts can be run.

Headless
Go to odh-dashboard/frontend/src/tests/cypress and run the command npx cypress run --spec "cypress/tests/e2e/dataScienceProjects/connections/testDataConnectionCreation.cy.ts" --browser chrome

or Execute 'npx cypress run --env grepTags=@ODS-1826'

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

antowaddle and others added 30 commits November 20, 2024 17:07
increase card timeout and delete active wait
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress This PR is in WIP state label Jan 27, 2025
@antowaddle antowaddle changed the title WIP - Cypress rhoaieng 17426 WIP - Cypress e2e Test - Verifies users can create/delete a PersistentVolume Jan 27, 2025
@antowaddle antowaddle closed this Jan 27, 2025
@antowaddle antowaddle reopened this Jan 27, 2025
@antowaddle antowaddle changed the title WIP - Cypress e2e Test - Verifies users can create/delete a PersistentVolume WIP - Cypress e2e Test - Verifies users can create/delete a Data Connection Jan 27, 2025
@antowaddle antowaddle changed the title WIP - Cypress e2e Test - Verifies users can create/delete a Data Connection Cypress e2e Test - Verifies users can create/delete a Data Connection Jan 27, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress This PR is in WIP state label Jan 27, 2025
Copy link
Contributor

@manosnoam manosnoam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comment. /lgtm

@antowaddle antowaddle requested a review from manosnoam January 28, 2025 09:54
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.16%. Comparing base (ddbd55a) to head (4284d5d).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3686      +/-   ##
==========================================
+ Coverage   84.15%   84.16%   +0.01%     
==========================================
  Files        1453     1453              
  Lines       33865    33865              
  Branches     9384     9384              
==========================================
+ Hits        28500    28504       +4     
+ Misses       5365     5361       -4     
Files with missing lines Coverage Δ
...rc/concepts/connectionTypes/ConnectionTypeForm.tsx 94.20% <ø> (ø)

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddbd55a...4284d5d. Read the comment docs.

Copy link
Contributor

openshift-ci bot commented Jan 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: manosnoam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 3167270 into opendatahub-io:main Jan 28, 2025
29 checks passed
@antowaddle antowaddle deleted the cypress-RHOAIENG-17426 branch January 28, 2025 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants