-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cypress e2e Test - Verifies users can create/delete a Data Connection #3686
Cypress e2e Test - Verifies users can create/delete a Data Connection #3686
Conversation
..._/cypress/cypress/tests/e2e/dataScienceProjects/connections/testDataConnectionCreation.cy.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor comment. /lgtm
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3686 +/- ##
==========================================
+ Coverage 84.15% 84.16% +0.01%
==========================================
Files 1453 1453
Lines 33865 33865
Branches 9384 9384
==========================================
+ Hits 28500 28504 +4
+ Misses 5365 5361 -4
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: manosnoam The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3167270
into
opendatahub-io:main
https://issues.redhat.com/browse/RHOAIENG-17426
Description
How Has This Been Tested?
Test Impact
How to run?
Go to odh-dashboard/frontend/src/tests/cypress and run the command npx cypress open . This will open the Cypress UI where testDataConnectionCreation.cy.ts can be run.
Headless
Go to odh-dashboard/frontend/src/tests/cypress and run the command npx cypress run --spec "cypress/tests/e2e/dataScienceProjects/connections/testDataConnectionCreation.cy.ts" --browser chrome
or Execute 'npx cypress run --env grepTags=@ODS-1826'
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main