Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cypress e2e] Verify Filters Are Working On Resources Page #3658

Merged
merged 4 commits into from
Jan 30, 2025

Conversation

manaswinidas
Copy link
Contributor

@manaswinidas manaswinidas commented Jan 20, 2025

Closes: RHOAIENG-17797

Description

Migrate ODS-489 to Cypress

Created a Cypress command to get card numbers checkbox labels In Resources page and compare the numbers of cards on that filter with the same.

How Has This Been Tested?

  • An oc login should be performed in the cluster before running the test
  • test-variables.yml should be configured properly
  • Export the path to the test-variables.yml: $ export CY_TEST_CONFIG=<path_to>/test-variables.yml
  • Locally against a PSI cluster and ODH-Nightly
Screenshot 2025-01-21 at 10 46 02 AM

Test Impact

After exporting the test-variables.yml we have 2 different ways:

Using the UI
Go to odh-dashboard/frontend/src/tests/cypress and run the command npx cypress open . This will open the Cypress UI where testResourcesFilters.cy.ts can be run.

Headless
Go to odh-dashboard/frontend/src/tests/cypress and run the command npx cypress run --spec "cypress/tests/e2e/learningResources/testResourcesFilters.cy.ts" --browser chrome

or Execute 'npx cypress run --env grepTags=@ODS-489'

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-ci openshift-ci bot requested review from lucferbux and ppadti January 20, 2025 14:44
@manaswinidas
Copy link
Contributor Author

/retest

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.15%. Comparing base (b368894) to head (7f6f582).
Report is 29 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3658      +/-   ##
==========================================
- Coverage   84.31%   84.15%   -0.16%     
==========================================
  Files        1443     1453      +10     
  Lines       33663    33865     +202     
  Branches     9320     9384      +64     
==========================================
+ Hits        28383    28500     +117     
- Misses       5280     5365      +85     

see 63 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b368894...7f6f582. Read the comment docs.

@ConorOM1
Copy link
Contributor

looks like the test isn't passing on RHOAI

@manaswinidas
Copy link
Contributor Author

WIP for figuring out how to get this working for both RHOAI and ODH clusters.

@manaswinidas manaswinidas added the do-not-merge/work-in-progress This PR is in WIP state label Jan 21, 2025
@manaswinidas manaswinidas removed the do-not-merge/work-in-progress This PR is in WIP state label Jan 28, 2025
@manaswinidas
Copy link
Contributor Author

manaswinidas commented Jan 28, 2025

After a discussion with @ConorOM1 and according to the Robot test I'm covering .. creating an oc get for OdhDocument does not serve our purpose, a lot of cards are OdhQuickStart and OdhLink, which depends on OdhApplication - after checking the robot test, the test was comparing the number of cards with the number in the checkbox, I made the changes accordingly. I've also tested the tests against both RHOAI and ODH clusters.

Copy link
Contributor

@antowaddle antowaddle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@manaswinidas Thanks for helping to convert this test, really appreciate it. I've left some minor comments.

@ConorOM1
Copy link
Contributor

/lgtm

@antowaddle
Copy link
Contributor

antowaddle commented Jan 30, 2025

Ran the test and it passes, thanks @manaswinidas for making the changes.
image

@antowaddle
Copy link
Contributor

/approved

Copy link
Contributor

openshift-ci bot commented Jan 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 248b208 into opendatahub-io:main Jan 30, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants