-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cypress e2e] Verify Filters Are Working On Resources Page #3658
[Cypress e2e] Verify Filters Are Working On Resources Page #3658
Conversation
frontend/src/__tests__/cypress/cypress/tests/e2e/learningResources/testResourcesfilters.cy.ts
Outdated
Show resolved
Hide resolved
/retest |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3658 +/- ##
==========================================
- Coverage 84.31% 84.15% -0.16%
==========================================
Files 1443 1453 +10
Lines 33663 33865 +202
Branches 9320 9384 +64
==========================================
+ Hits 28383 28500 +117
- Misses 5280 5365 +85 see 63 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
looks like the test isn't passing on RHOAI |
WIP for figuring out how to get this working for both RHOAI and ODH clusters. |
After a discussion with @ConorOM1 and according to the Robot test I'm covering .. creating an |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@manaswinidas Thanks for helping to convert this test, really appreciate it. I've left some minor comments.
frontend/src/__tests__/cypress/cypress/tests/e2e/learningResources/testResourcesfilters.cy.ts
Outdated
Show resolved
Hide resolved
frontend/src/__tests__/cypress/cypress/tests/e2e/learningResources/testResourcesfilters.cy.ts
Outdated
Show resolved
Hide resolved
frontend/src/__tests__/cypress/cypress/tests/e2e/learningResources/testResourcesfilters.cy.ts
Outdated
Show resolved
Hide resolved
/lgtm |
Ran the test and it passes, thanks @manaswinidas for making the changes. |
/approved |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
248b208
into
opendatahub-io:main
Closes: RHOAIENG-17797
Description
Migrate ODS-489 to Cypress
Created a Cypress command to get card numbers checkbox labels In Resources page and compare the numbers of cards on that filter with the same.
How Has This Been Tested?
Test Impact
After exporting the test-variables.yml we have 2 different ways:
Using the UI
Go to odh-dashboard/frontend/src/tests/cypress and run the command npx cypress open . This will open the Cypress UI where testResourcesFilters.cy.ts can be run.
Headless
Go to odh-dashboard/frontend/src/tests/cypress and run the command npx cypress run --spec "cypress/tests/e2e/learningResources/testResourcesFilters.cy.ts" --browser chrome
or Execute 'npx cypress run --env grepTags=@ODS-489'
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main