-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply hardware profile to notebook image settings table #3645
base: main
Are you sure you want to change the base?
Apply hardware profile to notebook image settings table #3645
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3645 +/- ##
==========================================
- Coverage 85.79% 85.71% -0.08%
==========================================
Files 1419 1421 +2
Lines 32688 32750 +62
Branches 9195 9212 +17
==========================================
+ Hits 28044 28071 +27
- Misses 4644 4679 +35
... and 11 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
@DaoDaoNoCode , I created notebook image with a new option(ex: gpu) for rest of the functionality mentioned are working as expected |
@DaoDaoNoCode , thanks for the changes, that works well |
JIRA: RHOAIENG-16258
Description
Apply the hardware profiles to the notebook image settings page. This remains unchanged when the hardware profile flag is disabled. When it's enabled, do the following changes:
Recommended identifiers
withRecommended hardware profiles
and put all the hardware profiles that has the selected identifier (as long as at least one identifier is included in the hardware profile node resources, we think that hardware profile is recommended)How Has This Been Tested?
Test Impact
Added a unit test to test the recommended hardware profile filter function, and added a cypress test to test the pre-fill node resources table based on the search params in the URL.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main